summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2016-07-06 22:41:24 -0500
committerAaron Durbin <adurbin@chromium.org>2016-07-07 20:44:43 +0200
commita790f1b0852158032b5c6993209b580d0b2c659e (patch)
treed797c66033917bb6edeabe6dedb7ddb09ea64d94 /src
parentf41ac2298eb61f2a524731a07c915416d562f17c (diff)
soc/intel/apollolake: make internal pulls weak for gpio inputs
The internal pulls for gpio_input_pullup() and gpio_input_pulldown() were using fairly strong pulls. Weaken them so that external pulls can override the internal ones. This matches the current assumptions of lib/gpio.c. BUG=chrome-os-partner:54949 BRANCH=None TEST=Built and used on reef for memory config. Change-Id: Ifda1d04d40141325f78db277eb0bd55574994abf Signed-off-by: Aaron Durbin <adurbin@chromuim.org> Reviewed-on: https://review.coreboot.org/15558 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Andrey Petrov <andrey.petrov@intel.com> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/soc/intel/apollolake/gpio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c
index 525c972b5c..699c8fea28 100644
--- a/src/soc/intel/apollolake/gpio.c
+++ b/src/soc/intel/apollolake/gpio.c
@@ -71,13 +71,13 @@ void gpio_configure_pads(const struct pad_config *cfg, size_t num_pads)
void gpio_input_pulldown(gpio_t gpio)
{
- struct pad_config cfg = PAD_CFG_GPI(gpio, DN_5K, DEEP);
+ struct pad_config cfg = PAD_CFG_GPI(gpio, DN_20K, DEEP);
gpio_configure_pad(&cfg);
}
void gpio_input_pullup(gpio_t gpio)
{
- struct pad_config cfg = PAD_CFG_GPI(gpio, UP_5K, DEEP);
+ struct pad_config cfg = PAD_CFG_GPI(gpio, UP_20K, DEEP);
gpio_configure_pad(&cfg);
}