From a790f1b0852158032b5c6993209b580d0b2c659e Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Wed, 6 Jul 2016 22:41:24 -0500 Subject: soc/intel/apollolake: make internal pulls weak for gpio inputs The internal pulls for gpio_input_pullup() and gpio_input_pulldown() were using fairly strong pulls. Weaken them so that external pulls can override the internal ones. This matches the current assumptions of lib/gpio.c. BUG=chrome-os-partner:54949 BRANCH=None TEST=Built and used on reef for memory config. Change-Id: Ifda1d04d40141325f78db277eb0bd55574994abf Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/15558 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Andrey Petrov Reviewed-by: Furquan Shaikh --- src/soc/intel/apollolake/gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c index 525c972b5c..699c8fea28 100644 --- a/src/soc/intel/apollolake/gpio.c +++ b/src/soc/intel/apollolake/gpio.c @@ -71,13 +71,13 @@ void gpio_configure_pads(const struct pad_config *cfg, size_t num_pads) void gpio_input_pulldown(gpio_t gpio) { - struct pad_config cfg = PAD_CFG_GPI(gpio, DN_5K, DEEP); + struct pad_config cfg = PAD_CFG_GPI(gpio, DN_20K, DEEP); gpio_configure_pad(&cfg); } void gpio_input_pullup(gpio_t gpio) { - struct pad_config cfg = PAD_CFG_GPI(gpio, UP_5K, DEEP); + struct pad_config cfg = PAD_CFG_GPI(gpio, UP_20K, DEEP); gpio_configure_pad(&cfg); } -- cgit v1.2.3