aboutsummaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2022-11-24 15:51:48 +0530
committerSubrata Banik <subratabanik@google.com>2022-11-26 08:41:56 +0000
commita3c0ba12eb0f5f89133789db0d19f5dff0ed0a7f (patch)
tree5fb8dbc8adc9fe830600fbac097e0a8b2effc1cf /src/soc
parentda527ec12b01d4794c2b99576dc49bfedadac767 (diff)
soc/intel/alderlake: Use common code CSE-Lite API for WP information
This patch drops the local implementation `log_me_ro_write_protection_info` and adopts the API from IA common code (cse_lite.c). BUG=none TEST=Able to compile the cse_lite.c file for google/kano without any error. Signed-off-by: Subrata Banik <subratabanik@google.com> Change-Id: I087ffb8ac94f14a6bd7f2bf6bb907c4047dc9899 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69969 Reviewed-by: Kapil Porwal <kapilporwal@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/alderlake/me.c25
1 files changed, 1 insertions, 24 deletions
diff --git a/src/soc/intel/alderlake/me.c b/src/soc/intel/alderlake/me.c
index 4937cedeac..8b5e94f265 100644
--- a/src/soc/intel/alderlake/me.c
+++ b/src/soc/intel/alderlake/me.c
@@ -2,7 +2,6 @@
#include <bootstate.h>
#include <intelblocks/cse.h>
-#include <intelblocks/spi.h>
#include <console/console.h>
#include <soc/me.h>
#include <stdint.h>
@@ -88,28 +87,6 @@ union me_hfsts6 {
} __packed fields;
};
-static void log_me_ro_write_protection_info(bool mfg_mode)
-{
- bool cse_ro_wp_en = is_spi_wp_cse_ro_en();
-
- printk(BIOS_DEBUG, "ME: WP for RO is enabled : %s\n",
- cse_ro_wp_en ? "YES" : "NO");
-
- if (cse_ro_wp_en) {
- uint32_t base, limit;
- spi_get_wp_cse_ro_range(&base, &limit);
- printk(BIOS_DEBUG, "ME: RO write protection scope - Start=0x%X, End=0x%X\n",
- base, limit);
- }
-
- /*
- * If manufacturing mode is disabled, but CSE RO is not write protected,
- * log error.
- */
- if (!mfg_mode && !cse_ro_wp_en)
- printk(BIOS_ERR, "ME: Write protection for CSE RO is not enabled\n");
-}
-
static bool is_manuf_mode(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6)
{
/*
@@ -195,7 +172,7 @@ static void dump_me_status(void *unused)
hfsts6.fields.txt_support ? "YES" : "NO");
if (CONFIG(SOC_INTEL_CSE_LITE_SKU))
- log_me_ro_write_protection_info(manuf_mode);
+ cse_log_ro_write_protection_info(manuf_mode);
}
BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_EXIT, print_me_fw_version, NULL);