From a3c0ba12eb0f5f89133789db0d19f5dff0ed0a7f Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Thu, 24 Nov 2022 15:51:48 +0530 Subject: soc/intel/alderlake: Use common code CSE-Lite API for WP information MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch drops the local implementation `log_me_ro_write_protection_info` and adopts the API from IA common code (cse_lite.c). BUG=none TEST=Able to compile the cse_lite.c file for google/kano without any error. Signed-off-by: Subrata Banik Change-Id: I087ffb8ac94f14a6bd7f2bf6bb907c4047dc9899 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69969 Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/soc/intel/alderlake/me.c | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/alderlake/me.c b/src/soc/intel/alderlake/me.c index 4937cedeac..8b5e94f265 100644 --- a/src/soc/intel/alderlake/me.c +++ b/src/soc/intel/alderlake/me.c @@ -2,7 +2,6 @@ #include #include -#include #include #include #include @@ -88,28 +87,6 @@ union me_hfsts6 { } __packed fields; }; -static void log_me_ro_write_protection_info(bool mfg_mode) -{ - bool cse_ro_wp_en = is_spi_wp_cse_ro_en(); - - printk(BIOS_DEBUG, "ME: WP for RO is enabled : %s\n", - cse_ro_wp_en ? "YES" : "NO"); - - if (cse_ro_wp_en) { - uint32_t base, limit; - spi_get_wp_cse_ro_range(&base, &limit); - printk(BIOS_DEBUG, "ME: RO write protection scope - Start=0x%X, End=0x%X\n", - base, limit); - } - - /* - * If manufacturing mode is disabled, but CSE RO is not write protected, - * log error. - */ - if (!mfg_mode && !cse_ro_wp_en) - printk(BIOS_ERR, "ME: Write protection for CSE RO is not enabled\n"); -} - static bool is_manuf_mode(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6) { /* @@ -195,7 +172,7 @@ static void dump_me_status(void *unused) hfsts6.fields.txt_support ? "YES" : "NO"); if (CONFIG(SOC_INTEL_CSE_LITE_SKU)) - log_me_ro_write_protection_info(manuf_mode); + cse_log_ro_write_protection_info(manuf_mode); } BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_EXIT, print_me_fw_version, NULL); -- cgit v1.2.3