diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-06-08 11:25:29 +0300 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-10-22 14:15:52 +0000 |
| commit | ea6d12a0de8af000fb72a873b63364462f280643 (patch) | |
| tree | d2dc78444c6a3447641bab81b10bc2018a9ea056 /src/soc/intel/common/block | |
| parent | 6139ff9c9aa0b941b1c178058e4d10baa23fff70 (diff) | |
sb,soc/intel: Set IOAPIC max entries before APIC ID
This allows to replace set_ioapic_id() call with setup_ioapic()
that also clears redirection table entries.
Change-Id: I854f19c997a96bcdccb11a0906431e3291788cb6
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55308
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/soc/intel/common/block')
| -rw-r--r-- | src/soc/intel/common/block/lpc/lpc_lib.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c index c2278df248..43434df0af 100644 --- a/src/soc/intel/common/block/lpc/lpc_lib.c +++ b/src/soc/intel/common/block/lpc/lpc_lib.c @@ -280,10 +280,10 @@ void lpc_disable_clkrun(void) /* Enable PCH IOAPIC */ void pch_enable_ioapic(void) { - set_ioapic_id((void *)IO_APIC_ADDR, 0x02); - /* affirm full set of redirection table entries ("write once") */ ioapic_set_max_vectors(VIO_APIC_VADDR, PCH_REDIR_ETR); + + set_ioapic_id((void *)IO_APIC_ADDR, 0x02); } static const uint8_t pch_interrupt_routing[PIRQ_COUNT] = { |