From ea6d12a0de8af000fb72a873b63364462f280643 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 8 Jun 2021 11:25:29 +0300 Subject: sb,soc/intel: Set IOAPIC max entries before APIC ID MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This allows to replace set_ioapic_id() call with setup_ioapic() that also clears redirection table entries. Change-Id: I854f19c997a96bcdccb11a0906431e3291788cb6 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/55308 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/soc/intel/common/block/lpc/lpc_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/soc/intel/common/block') diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c index c2278df248..43434df0af 100644 --- a/src/soc/intel/common/block/lpc/lpc_lib.c +++ b/src/soc/intel/common/block/lpc/lpc_lib.c @@ -280,10 +280,10 @@ void lpc_disable_clkrun(void) /* Enable PCH IOAPIC */ void pch_enable_ioapic(void) { - set_ioapic_id((void *)IO_APIC_ADDR, 0x02); - /* affirm full set of redirection table entries ("write once") */ ioapic_set_max_vectors(VIO_APIC_VADDR, PCH_REDIR_ETR); + + set_ioapic_id((void *)IO_APIC_ADDR, 0x02); } static const uint8_t pch_interrupt_routing[PIRQ_COUNT] = { -- cgit v1.2.3