diff options
| author | Krishna Prasad Bhat <krishna.p.bhat.d@intel.com> | 2022-02-09 14:55:38 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-02-12 17:25:57 +0000 |
| commit | b2e9193231e002b2a3bb33a80d18f76b9abc0a10 (patch) | |
| tree | 1c822fbfabe9e32c8ac480707ee720afcfcf3a88 /src/mainboard/google/brya/variants/baseboard | |
| parent | f91538c3eca7529810922ee6f39ff2ea767162fa (diff) | |
mb/google/nissa: Set half_populated true
Alder Lake N has single memory controller with 64-bit bus width. Alder
Lake common meminit block driver considers bus width to be 128-bit and
populates the meminit data accordingly. By setting half_populated to
true, only the bottom half is populated.
Ideally, half_populated is used in platforms with multiple channels to
enable only one half of the channel. Alder Lake N has single channel,
and it would require for new structures to be defined in meminit block
driver for LPx memory configurations. In order to avoid adding new
structures, set half_populated to true. This has the same effect as
having single channel with 64-bit width.
Change-Id: I414e5dc82caf47b6b96c474b3ef6e01c2ce0226e
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d@intel.com>
Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61764
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Reka Norman <rekanorman@chromium.org>
Reviewed-by: Kangheui Won <khwon@chromium.org>
Diffstat (limited to 'src/mainboard/google/brya/variants/baseboard')
| -rw-r--r-- | src/mainboard/google/brya/variants/baseboard/nissa/memory.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/memory.c b/src/mainboard/google/brya/variants/baseboard/nissa/memory.c index d4f9a0b7b7..b74d3345ff 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/memory.c +++ b/src/mainboard/google/brya/variants/baseboard/nissa/memory.c @@ -97,8 +97,15 @@ int __weak variant_memory_sku(void) bool __weak variant_is_half_populated(void) { - /* ADL-N only has a single memory channel. */ - return false; + /* + * Ideally half_populated is used in platforms with multiple channels to + * enable only one half of the channel. Alder Lake N has single channel, + * and it would require for new structures to be defined in meminit block + * driver for LPx memory configurations. In order to avoid adding new + * structures, set half_populated to true. This has the same effect as + * having single channel with 64-bit width. + */ + return true; } void __weak variant_get_spd_info(struct mem_spd *spd_info) |