From b2e9193231e002b2a3bb33a80d18f76b9abc0a10 Mon Sep 17 00:00:00 2001 From: Krishna Prasad Bhat Date: Wed, 9 Feb 2022 14:55:38 +0530 Subject: mb/google/nissa: Set half_populated true Alder Lake N has single memory controller with 64-bit bus width. Alder Lake common meminit block driver considers bus width to be 128-bit and populates the meminit data accordingly. By setting half_populated to true, only the bottom half is populated. Ideally, half_populated is used in platforms with multiple channels to enable only one half of the channel. Alder Lake N has single channel, and it would require for new structures to be defined in meminit block driver for LPx memory configurations. In order to avoid adding new structures, set half_populated to true. This has the same effect as having single channel with 64-bit width. Change-Id: I414e5dc82caf47b6b96c474b3ef6e01c2ce0226e Signed-off-by: Krishna Prasad Bhat Signed-off-by: Rizwan Qureshi Reviewed-on: https://review.coreboot.org/c/coreboot/+/61764 Tested-by: build bot (Jenkins) Reviewed-by: Reka Norman Reviewed-by: Kangheui Won --- src/mainboard/google/brya/variants/baseboard/nissa/memory.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'src/mainboard/google/brya/variants/baseboard') diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/memory.c b/src/mainboard/google/brya/variants/baseboard/nissa/memory.c index d4f9a0b7b7..b74d3345ff 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/memory.c +++ b/src/mainboard/google/brya/variants/baseboard/nissa/memory.c @@ -97,8 +97,15 @@ int __weak variant_memory_sku(void) bool __weak variant_is_half_populated(void) { - /* ADL-N only has a single memory channel. */ - return false; + /* + * Ideally half_populated is used in platforms with multiple channels to + * enable only one half of the channel. Alder Lake N has single channel, + * and it would require for new structures to be defined in meminit block + * driver for LPx memory configurations. In order to avoid adding new + * structures, set half_populated to true. This has the same effect as + * having single channel with 64-bit width. + */ + return true; } void __weak variant_get_spd_info(struct mem_spd *spd_info) -- cgit v1.2.3