diff options
| author | Sean Rhodes <sean@starlabs.systems> | 2024-09-03 11:16:26 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-09-06 13:03:53 +0000 |
| commit | 9f6cb3e6117665b3aef3d90d963a7d2e260050ff (patch) | |
| tree | 91dbf59f9f847d47b6d1591cc0d8780a29e39dee | |
| parent | 14292729e8531fc171acc76abab55902abd5ef6f (diff) | |
drivers/i2c/generic: Remove erroneous acpigen_pop_len
There are one too many acpigen_pop_len calls in the code
to generate the ROTM; remove one to fix an EMERG warning:
[EMERG] ASSERTION_ERROR: file `src/acpi/acpigen.c`, line 38
The extra acpigen_pop_len() call was added commit
45d2c3d5436e ("i2c/drivers/generic: Return ROTM in a package").
Change-Id: I913022144813f7f65eac1bcb7c97656f2c513c0b
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84197
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
| -rw-r--r-- | src/drivers/i2c/generic/generic.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 27bef49218..260ea83b10 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -165,7 +165,6 @@ void i2c_generic_fill_ssdt(const struct device *dev, acpigen_write_return_namestr("RBUF"); acpigen_pop_len(); - acpigen_pop_len(); } /* Chip Direct Mapping */ |