From 9f6cb3e6117665b3aef3d90d963a7d2e260050ff Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 3 Sep 2024 11:16:26 +0100 Subject: drivers/i2c/generic: Remove erroneous acpigen_pop_len There are one too many acpigen_pop_len calls in the code to generate the ROTM; remove one to fix an EMERG warning: [EMERG] ASSERTION_ERROR: file `src/acpi/acpigen.c`, line 38 The extra acpigen_pop_len() call was added commit 45d2c3d5436e ("i2c/drivers/generic: Return ROTM in a package"). Change-Id: I913022144813f7f65eac1bcb7c97656f2c513c0b Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/84197 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/drivers/i2c/generic/generic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 27bef49218..260ea83b10 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -165,7 +165,6 @@ void i2c_generic_fill_ssdt(const struct device *dev, acpigen_write_return_namestr("RBUF"); acpigen_pop_len(); - acpigen_pop_len(); } /* Chip Direct Mapping */ -- cgit v1.2.3