diff options
author | Nico Huber <nico.h@gmx.de> | 2022-08-06 19:02:59 +0200 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-15 13:06:47 +0000 |
commit | c0fc38eed8f407d71f714f4d6fe2af0c3501ece4 (patch) | |
tree | 0ac92ac61db931ff23fd91205d4fd1e057f368d0 /util/sconfig/sconfig.l | |
parent | f1ba7d6c8f844110c2bc05fa26e4cea9038672db (diff) |
sconfig: Allow to specify device operations
Currently we only have runtime mechanisms to assign device operations to
a node in our devicetree (with one exception: the root device). The most
common method is to map PCI IDs to the device operations with a `struct
pci_driver`. Another accustomed way is to let a chip driver assign them.
For very common drivers, e.g. those in soc/intel/common/blocks/, the PCI
ID lists grew very large and are incredibly error-prone. Often, IDs are
missing and sometimes IDs are added almost mechanically without checking
the code for compatibility. Maintaining these lists in a central place
also reduces flexibility.
Now, for onboard devices it is actually unnecessary to assign the device
operations at runtime. We already know exactly what operations should be
assigned. And since we are using chipset devicetrees, we have a perfect
place to put that information.
This patch adds a simple mechanism to `sconfig`. It allows us to speci-
fy operations per device, e.g.
device pci 00.0 alias system_agent on
ops system_agent_ops
end
The operations are given as a C identifier. In this example, we simply
assume that a global `struct device_operations system_agent_ops` exists.
Change-Id: I2833d2f2450fde3206c33393f58b86fd4280b566
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66483
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'util/sconfig/sconfig.l')
-rw-r--r-- | util/sconfig/sconfig.l | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/util/sconfig/sconfig.l b/util/sconfig/sconfig.l index 0997ff6444..5ff144b445 100644 --- a/util/sconfig/sconfig.l +++ b/util/sconfig/sconfig.l @@ -14,6 +14,7 @@ int linenum = 0; chip {return(CHIP);} device {return(DEVICE);} alias {return(ALIAS);} +ops {return(OPS);} use {return(REFERENCE);} ref {return(REFERENCE);} as {return(ASSOCIATION);} |