summaryrefslogtreecommitdiff
path: root/util/mainboard
diff options
context:
space:
mode:
authorZheng Bao <fishbaozi@gmail.com>2020-10-27 15:36:55 +0800
committerFelix Held <felix-coreboot@felixheld.de>2020-11-06 13:02:24 +0000
commit795d73c6d851fde143041483af5dff7c448febe6 (patch)
treea44a592eebe49f10e82bf5d07861d69bd663f5d1 /util/mainboard
parent0cae9008f01af3cd89dad317d42292c04b53bb51 (diff)
soc/amd/picasso: Update coreboot UPD variable names to include units
Use command below to change the variable globally. sed -i "s/\<variable\>/variable_u/g" `grep variable -rl ./ \ --exclude-dir=build --exclude-dir=crossgcc` BUG=b:171334623 TEST=Build Change-Id: I056a76663e84ebc940343d64178c18cb20df01a3 Signed-off-by: Zheng Bao <fishbaozi@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46840 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'util/mainboard')
-rw-r--r--util/mainboard/google/dalboz/template/overridetree.cb10
-rw-r--r--util/mainboard/google/trembyle/template/overridetree.cb14
2 files changed, 12 insertions, 12 deletions
diff --git a/util/mainboard/google/dalboz/template/overridetree.cb b/util/mainboard/google/dalboz/template/overridetree.cb
index 7645ba33e3..1cc2364f5e 100644
--- a/util/mainboard/google/dalboz/template/overridetree.cb
+++ b/util/mainboard/google/dalboz/template/overridetree.cb
@@ -10,11 +10,11 @@ chip soc/amd/picasso
register "system_config" = "1"
# Set STAPM confiuration. All of these fields must be set >0 to take affect
- register "slow_ppt_limit" = "6000" #mw
- register "fast_ppt_limit" = "9000" #mw
- register "slow_ppt_time_constant" = "5" #second
- register "stapm_time_constant" = "2500" #second
- register "sustained_power_limit" = "4800" #mw
+ register "slow_ppt_limit_mW" = "6000"
+ register "fast_ppt_limit_mW" = "9000"
+ register "slow_ppt_time_constant_s" = "5"
+ register "stapm_time_constant_s" = "2500"
+ register "sustained_power_limit_mW" = "4800"
# End : OPN Performance Configuration
diff --git a/util/mainboard/google/trembyle/template/overridetree.cb b/util/mainboard/google/trembyle/template/overridetree.cb
index d332fce28e..6f545b2402 100644
--- a/util/mainboard/google/trembyle/template/overridetree.cb
+++ b/util/mainboard/google/trembyle/template/overridetree.cb
@@ -10,15 +10,15 @@ chip soc/amd/picasso
register "system_config" = "2"
# Set STAPM confiuration. All of these fields must be set >0 to take affect
- register "slow_ppt_limit" = "25000" #mw
- register "fast_ppt_limit" = "30000" #mw
- register "slow_ppt_time_constant" = "5" #second
- register "stapm_time_constant" = "200" #second
- register "sustained_power_limit" = "15000" #mw
+ register "slow_ppt_limit_mW" = "25000"
+ register "fast_ppt_limit_mW" = "30000"
+ register "slow_ppt_time_constant_s" = "5"
+ register "stapm_time_constant_s" = "200"
+ register "sustained_power_limit_mW" = "15000"
- register "telemetry_vddcr_vdd_slope" = "71222" #mA
+ register "telemetry_vddcr_vdd_slope_mA" = "71222"
register "telemetry_vddcr_vdd_offset" = "0"
- register "telemetry_vddcr_soc_slope" = "28977" #mA
+ register "telemetry_vddcr_soc_slope_mA" = "28977"
register "telemetry_vddcr_soc_offset" = "0"
# End : OPN Performance Configuration