summaryrefslogtreecommitdiff
path: root/util/lint/lint-stable-003-whitespace
diff options
context:
space:
mode:
authorMartin Roth <martin@coreboot.org>2022-06-03 00:06:57 -0600
committerMartin L Roth <gaumless@gmail.com>2022-09-30 19:19:53 +0000
commitd81debd9467f7e0d5a255ed7f6b5f1916c613b77 (patch)
tree224623fc3af10180d652c7c0d7c39925e74e3763 /util/lint/lint-stable-003-whitespace
parent7726a7f272965d9279e4c8008b893751203aa304 (diff)
util/lint: Update tools that use git to use a library
Each of the tools that used git had similar functionality. This combines all of that into a single script that gets sourced by each. This makes maintenance much easier. By doing this and updating each of the scripts to do the correct thing if the script isn't being run in a git repository, it makes them work much better for the releases, which are just released as a tarball, without any attached git repository. Change-Id: I61ba1cc4f7205e0d4baf993588bbc774120405cb Signed-off-by: Martin Roth <martin@coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/64973 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'util/lint/lint-stable-003-whitespace')
-rwxr-xr-xutil/lint/lint-stable-003-whitespace12
1 files changed, 9 insertions, 3 deletions
diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace
index 5174120673..e46d93e2a4 100755
--- a/util/lint/lint-stable-003-whitespace
+++ b/util/lint/lint-stable-003-whitespace
@@ -4,20 +4,26 @@
# DESCR: Check for superfluous whitespace in the tree
-LC_ALL=C export LC_ALL
+INTDIR="$(
+ cd -- "$(dirname "$0")" > /dev/null 2>&1 || return
+ pwd -P
+)"
+# shellcheck source=helper_functions.sh
+. "${LINTDIR}/helper_functions.sh"
+
EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage$|^util/goswid$|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$'
INCLUDELIST="src util payloads Makefile* toolchain.inc tests"
# shellcheck disable=SC2086,SC2046
if uname | grep -qi "linux"; then
grep -n -H "[[:space:]][[:space:]]*$" \
- $(git ls-files $INCLUDELIST | \
+ $(${FIND_FILES} $INCLUDELIST | \
grep -Ev "($EXCLUDELIST)" ) | \
sed -e "s,^.*$,File & has lines ending with whitespace.,"
else
# The above form is much (100x) faster, but doesn't work
# on all systems. A for loop also works but takes 30% longer
- git ls-files $INCLUDELIST | \
+ ${FIND_FILES} $INCLUDELIST | \
grep -Ev "($EXCLUDELIST)" | \
xargs -I % \
grep -l "[[:space:]][[:space:]]*$" % | \