summaryrefslogtreecommitdiff
path: root/util/genbuild_h
diff options
context:
space:
mode:
authorMartin Roth <gaumless@gmail.com>2023-07-31 09:59:07 -0600
committerFelix Singer <service+coreboot-gerrit@felixsinger.de>2023-08-21 22:31:10 +0000
commitfd63492205dfb22fdcad663f6b1c6a589ac4b035 (patch)
treed1883b2e9dbfedd842fa0b922f9699c46513ded8 /util/genbuild_h
parentc25f00acfa381703d9ccff4fa5db3b10162b7ab2 (diff)
util/genbuild: Correctly remove IASL warning
If IASL isn't installed, the genbuild script throws a confusing warning. This can and should be ignored because toolchain.inc will find this and provide a much better error message. The trailing >/dev/null was probably intended to do this, but didn't actually affect anything. Adding quotes around the IASL command will make "" be the command that tries to get run instead of `-v` when IASL isn't present. This will always be a failure, whereas `-v` could theoretically be a valid command. Signed-off-by: Martin Roth <gaumless@gmail.com> Change-Id: Ibff93db670766c4de21faa7553f2003450465407 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76857 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Diffstat (limited to 'util/genbuild_h')
-rwxr-xr-xutil/genbuild_h/genbuild_h.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh
index 5e2fe7df8f..2bfcc4c3b6 100755
--- a/util/genbuild_h/genbuild_h.sh
+++ b/util/genbuild_h/genbuild_h.sh
@@ -70,7 +70,7 @@ eval "$(grep ^IASL:= "${XCOMPILE}" 2>/dev/null | sed s,:=,=,)"
if [ ! -x "${IASL}" ]; then
IASL=$(command -v iasl)
fi
-IASLVERSION="$(${IASL} -v | grep version | sed 's/.*version //')" >/dev/null
+IASLVERSION="$("${IASL}" -v 2>/dev/null | grep version | sed 's/.*version //')"
#Print out the information that goes into build.h
printf "/* build system definitions (autogenerated) */\n"