summaryrefslogtreecommitdiff
path: root/util/cbfstool/Makefile.inc
diff options
context:
space:
mode:
authorHung-Te Lin <hungte@chromium.org>2013-01-30 00:43:46 +0800
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-02-05 22:24:45 +0100
commit3cfacbf1961accff8670997368b403d8068ad94c (patch)
treeb754b647c166bc27da1e44f5dfca40d63bafdd87 /util/cbfstool/Makefile.inc
parentf04e68e9e2a651b5db4d769d20d78d807426f109 (diff)
cbfstool: Add buffer management API.
Many functions in cbfstool need to deal with a memory buffer - both location and size. Right now it's made by different ways: for ROM image using global variable (romsize, master_header); and in cbfs-* using return value for size and char** to return memory location. This may cause bugs like assuming incorrect return types, ex: uint32_t file_size = parse(); // which returns "-1" on error if (file_size <= 0) { ... And the parse error will never be caught. We can simplify this by introducing a buffer API, to change unsigned int do_something(char *input, size_t len, char **output, ...) into int do_something(struct buffer *input, struct buffer *output, ...) The buffer API will be used by further commits. Change-Id: Iaddaeb109f08be6be84c6728d72c6a043b0e7a9f Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: http://review.coreboot.org/2205 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'util/cbfstool/Makefile.inc')
0 files changed, 0 insertions, 0 deletions