diff options
| author | Subrata Banik <subratabanik@google.com> | 2023-03-16 18:25:45 +0530 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2023-03-19 07:17:23 +0000 |
| commit | ecb4a24eaa720b4c7be506b0986f7797a3d8dbf6 (patch) | |
| tree | 7de12e7349508cdd0980289f742687c8ddcc29da /src | |
| parent | 7877ceda9e3a19a6fa6d0f3ca919ae7c194173e8 (diff) | |
soc/intel/mtl: Choose serial msg `log_level` based on DIMM count
This patch modifies the serial msg log_level at runtime to highlight
an ERROR if the DIMM count is zero. It would help to draw the
attention while parsing the serial msg and catch any underlying issue.
TEST=Able to see ERROR msg while booting google/rex with FSP v3064
Without this patch:
[DEBUG] 0 DIMMs found
With this patch:
[ERROR] No DIMMs found
Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: Iacf41efecb4962f91cf322bbc50636dc44033e3e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73756
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Dinesh Gehlot <digehlot@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/intel/meteorlake/romstage/romstage.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/soc/intel/meteorlake/romstage/romstage.c b/src/soc/intel/meteorlake/romstage/romstage.c index 340716fd23..2df3e11d7a 100644 --- a/src/soc/intel/meteorlake/romstage/romstage.c +++ b/src/soc/intel/meteorlake/romstage/romstage.c @@ -114,7 +114,10 @@ static void save_dimm_info(void) } } mem_info->dimm_cnt = index; - printk(BIOS_DEBUG, "%d DIMMs found\n", mem_info->dimm_cnt); + if (mem_info->dimm_cnt == 0) + printk(BIOS_ERR, "No DIMMs found\n"); + else + printk(BIOS_DEBUG, "%d DIMMs found\n", mem_info->dimm_cnt); } void mainboard_romstage_entry(void) |