diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-03-03 18:00:16 +0100 |
|---|---|---|
| committer | Fred Reitberger <reitbergerfred@gmail.com> | 2023-03-06 13:18:42 +0000 |
| commit | e859d15d3456adbfce002e5e103dc7b7037edb8b (patch) | |
| tree | 81d23a02e7776a15416beb3e7a25560949282589 /src | |
| parent | 5d9a7cc1383fdf8b4e4b53e1928dcd06ce6885cd (diff) | |
soc/amd/*/acpi: drop unneeded mon_alrm FADT assignment
The FADT data structure is zero-initialized in acpi_create_fadt which
then calls the SoC-specific acpi_fill_fadt function, therefore it's not
needed to assign 0 to the mon_alrm FADT field in acpi_fill_fadt.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Iabb5fc7367f1e4e7acea1a58abdb643fc46ca776
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73418
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/amd/cezanne/acpi.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/glinda/acpi.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/mendocino/acpi.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/phoenix/acpi.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/picasso/acpi.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/acpi.c | 1 |
6 files changed, 0 insertions, 6 deletions
diff --git a/src/soc/amd/cezanne/acpi.c b/src/soc/amd/cezanne/acpi.c index 46eaadca57..89261cff78 100644 --- a/src/soc/amd/cezanne/acpi.c +++ b/src/soc/amd/cezanne/acpi.c @@ -83,7 +83,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->duty_offset = 0; /* Not supported */ fadt->duty_width = 0; /* Not supported */ fadt->day_alrm = RTC_DATE_ALARM; - fadt->mon_alrm = 0; fadt->century = RTC_ALT_CENTURY; fadt->iapc_boot_arch = cfg->common_config.fadt_boot_arch; /* legacy free default */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c index 675ab20f12..322e44e8af 100644 --- a/src/soc/amd/glinda/acpi.c +++ b/src/soc/amd/glinda/acpi.c @@ -86,7 +86,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->duty_offset = 0; /* Not supported */ fadt->duty_width = 0; /* Not supported */ fadt->day_alrm = RTC_DATE_ALARM; - fadt->mon_alrm = 0; fadt->century = RTC_ALT_CENTURY; fadt->iapc_boot_arch = cfg->common_config.fadt_boot_arch; /* legacy free default */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c index fb4d103aee..f5199174c5 100644 --- a/src/soc/amd/mendocino/acpi.c +++ b/src/soc/amd/mendocino/acpi.c @@ -85,7 +85,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->duty_offset = 0; /* Not supported */ fadt->duty_width = 0; /* Not supported */ fadt->day_alrm = RTC_DATE_ALARM; - fadt->mon_alrm = 0; fadt->century = RTC_ALT_CENTURY; fadt->iapc_boot_arch = cfg->common_config.fadt_boot_arch; /* legacy free default */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c index 25ebc66afd..f082518b1e 100644 --- a/src/soc/amd/phoenix/acpi.c +++ b/src/soc/amd/phoenix/acpi.c @@ -86,7 +86,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->duty_offset = 0; /* Not supported */ fadt->duty_width = 0; /* Not supported */ fadt->day_alrm = RTC_DATE_ALARM; - fadt->mon_alrm = 0; fadt->century = RTC_ALT_CENTURY; fadt->iapc_boot_arch = cfg->common_config.fadt_boot_arch; /* legacy free default */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index 138e743d0c..89ca50260f 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -89,7 +89,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->duty_offset = 1; /* CLK_VAL bits 3:1 */ fadt->duty_width = 3; /* CLK_VAL bits 3:1 */ fadt->day_alrm = RTC_DATE_ALARM; - fadt->mon_alrm = 0; fadt->iapc_boot_arch = cfg->fadt_boot_arch; /* legacy free default */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ ACPI_FADT_C1_SUPPORTED | diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index 3b45a5ff99..d60faafa43 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -81,7 +81,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->duty_offset = 1; /* CLK_VAL bits 3:1 */ fadt->duty_width = 3; /* CLK_VAL bits 3:1 */ fadt->day_alrm = RTC_DATE_ALARM; - fadt->mon_alrm = 0; /* Not supported */ fadt->iapc_boot_arch = FADT_BOOT_ARCH; /* See table 5-10 */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-10 ACPI 3.0a spec */ ACPI_FADT_C1_SUPPORTED | |