diff options
| author | Paul Menzel <paulepanter@users.sourceforge.net> | 2013-10-21 09:28:19 +0200 |
|---|---|---|
| committer | Aaron Durbin <adurbin@google.com> | 2013-10-30 16:18:04 +0100 |
| commit | d0299e4b5178ce8f8b986674cece3e07519f2dff (patch) | |
| tree | 3e1b0044d69f0b9bae8cc8e4ca6371d1c0a9bc63 /src | |
| parent | 1ce4860405d995585d08350481932238ee2f8c4a (diff) | |
southbridge/intel/i82801ix/lpc.c: Remove unused variable `dummy`
Removing `-Wno-unused-but-set-variable` from `CFLAGS` the build for
QEMU Q35 and Roda RK9, both using the Intel 82801Ix southbridge, fail
with the following error.
src/southbridge/intel/i82801ix/lpc.c: In function 'i82801ix_enable_apic':
src/southbridge/intel/i82801ix/lpc.c:45:5: error: variable 'dummy' set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
Removing `dummy` should be safe as GCC probably optimizes it away before
anyway. That no dummy variable is used for an RCBA [1] access in Intel
Lynx Point supports that this can be dropped safely.
[1] root complex base address
[2] src/southbridge/intel/lynxpoint/early_pch.c
Change-Id: I1c138a3498228dbd025f68d5e6af0acc29ed3460
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/3982
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/southbridge/intel/i82801ix/lpc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index fb0dd56ff5..bea0d98847 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -42,7 +42,6 @@ typedef struct southbridge_intel_i82801ix_config config_t; static void i82801ix_enable_apic(struct device *dev) { - u8 dummy; u32 reg32; volatile u32 *ioapic_index = (volatile u32 *)(IO_APIC_ADDR); volatile u32 *ioapic_data = (volatile u32 *)(IO_APIC_ADDR + 0x10); @@ -50,7 +49,7 @@ static void i82801ix_enable_apic(struct device *dev) /* Enable IOAPIC. Keep APIC Range Select at zero. */ RCBA8(0x31ff) = 0x03; /* We have to read 0x31ff back if bit0 changed. */ - dummy = RCBA8(0x31ff); + RCBA8(0x31ff); /* Lock maximum redirection entries (MRE), R/WO register. */ *ioapic_index = 0x01; |