diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2022-12-13 18:36:24 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-12-14 17:57:45 +0000 |
| commit | 993092039be26a4c822a05e345eada72654adf65 (patch) | |
| tree | 93c278eb2bb674658d1be1b3c66d62260f856cbf /src | |
| parent | 687ec6bd7203ad3f1fcf3c03c49d8255ac77d16e (diff) | |
soc/amd/*/config: drop invalid comment
Since commit 28e61f16341f ("device: Use __pci_0_00_0_config in
config_of_soc()") config_of_soc() was changed form being an actual
function to a macro for the __pci_0_00_0_config struct pointer generated
by util/sconfig. This change didn't only improve linker optimizations,
but also turned runtime errors into link-time errors, so it's guaranteed
that __pci_0_00_0_config won't be NULL and config_of_soc() won't
"return" NULL.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Id99ceaa9f7a70788da3f3068fb3da92d34fb6361
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70732
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/amd/cezanne/config.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/glinda/config.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/mendocino/config.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/morgana/config.c | 1 | ||||
| -rw-r--r-- | src/soc/amd/picasso/config.c | 1 |
5 files changed, 0 insertions, 5 deletions
diff --git a/src/soc/amd/cezanne/config.c b/src/soc/amd/cezanne/config.c index 577f2aeb97..5db488cfa5 100644 --- a/src/soc/amd/cezanne/config.c +++ b/src/soc/amd/cezanne/config.c @@ -6,7 +6,6 @@ const struct soc_amd_common_config *soc_get_common_config(void) { - /* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */ const struct soc_amd_cezanne_config *cfg = config_of_soc(); return &cfg->common_config; } diff --git a/src/soc/amd/glinda/config.c b/src/soc/amd/glinda/config.c index f667475302..371cfebaa3 100644 --- a/src/soc/amd/glinda/config.c +++ b/src/soc/amd/glinda/config.c @@ -6,7 +6,6 @@ const struct soc_amd_common_config *soc_get_common_config(void) { - /* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */ const struct soc_amd_glinda_config *cfg = config_of_soc(); return &cfg->common_config; } diff --git a/src/soc/amd/mendocino/config.c b/src/soc/amd/mendocino/config.c index 9030ed0dab..f1d335e472 100644 --- a/src/soc/amd/mendocino/config.c +++ b/src/soc/amd/mendocino/config.c @@ -8,7 +8,6 @@ const struct soc_amd_common_config *soc_get_common_config(void) { - /* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */ const struct soc_amd_mendocino_config *cfg = config_of_soc(); return &cfg->common_config; } diff --git a/src/soc/amd/morgana/config.c b/src/soc/amd/morgana/config.c index 161d86cd49..0728f15e44 100644 --- a/src/soc/amd/morgana/config.c +++ b/src/soc/amd/morgana/config.c @@ -6,7 +6,6 @@ const struct soc_amd_common_config *soc_get_common_config(void) { - /* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */ const struct soc_amd_morgana_config *cfg = config_of_soc(); return &cfg->common_config; } diff --git a/src/soc/amd/picasso/config.c b/src/soc/amd/picasso/config.c index f1384bb5b0..1836825ee3 100644 --- a/src/soc/amd/picasso/config.c +++ b/src/soc/amd/picasso/config.c @@ -6,7 +6,6 @@ const struct soc_amd_common_config *soc_get_common_config(void) { - /* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */ const struct soc_amd_picasso_config *cfg = config_of_soc(); return &cfg->common_config; } |