aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2018-11-04 12:25:25 +0100
committerPatrick Georgi <pgeorgi@google.com>2018-11-06 13:52:24 +0000
commit98a68ada47bdd0e48c9ecd2ec2d3af59d31a64dd (patch)
tree62870996e6bb7fb0a741021c017717405eed521f /src
parentb93796d624415fdc2ba608a1bd1089cbaaf93dc0 (diff)
x86/acpi.c: Be more verbose when finding the wakeup vector
Since S3 resume sometimes breaks when trying to find the wakeup vector, it is useful to log whether it errors or not. Since it is an error, print it as such. Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/29449 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src')
-rw-r--r--src/arch/x86/acpi.c14
1 files changed, 10 insertions, 4 deletions
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 24db7c085d..f54aa19271 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -1278,8 +1278,11 @@ void *acpi_find_wakeup_vector(void)
break;
}
- if (rsdp == NULL)
+ if (rsdp == NULL) {
+ printk(BIOS_ALERT,
+ "No RSDP found, wake up from S3 not possible.\n");
return NULL;
+ }
printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp);
rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address;
@@ -1294,15 +1297,18 @@ void *acpi_find_wakeup_vector(void)
fadt = NULL;
}
- if (fadt == NULL)
+ if (fadt == NULL) {
+ printk(BIOS_ALERT,
+ "No FADT found, wake up from S3 not possible.\n");
return NULL;
+ }
printk(BIOS_DEBUG, "FADT found at %p\n", fadt);
facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl;
if (facs == NULL) {
- printk(BIOS_DEBUG, "No FACS found, wake up from S3 not "
- "possible.\n");
+ printk(BIOS_ALERT,
+ "No FACS found, wake up from S3 not possible.\n");
return NULL;
}