diff options
| author | Kangheui Won <khwon@chromium.org> | 2021-05-20 10:02:00 +1000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-05-28 16:16:28 +0000 |
| commit | 9752725fe5d933943e77c9561c2f47110171d3ca (patch) | |
| tree | a22e87728fc1e78c28cbe3d9997c01bae5b98243 /src | |
| parent | 34d5f9130e40eab187ff8326503cc79803911b3a (diff) | |
soc/amd/picasso: fix MCACHE on psp_verstage RO boot
On RW boot path psp_verstage call cbfs_map which calls chain of
_cbfs_alloc, cbfs_boot_lookup and cbfs_get_boot_device. Then
cbfs_get_boot_device initializes MCACHE which is used later.
However on RO boot path psp_verstage doesn't try to find anything in the
CBFS which results RO MCACHE not to be initialized. Add
cbfs_get_boot_device(true) to explicitly initialize MCACHE on recovery
boot.
BUG=b:177091575
BRANCH=none
TEST=build and boot jelboz
Signed-off-by: Kangheui Won <khwon@chromium.org>
Change-Id: I6c4b522fef5a4affd215faa122bdf6b53190cf3d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/54711
Reviewed-by: Julius Werner <jwerner@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/amd/common/psp_verstage/psp_verstage.c | 10 | ||||
| -rw-r--r-- | src/soc/amd/picasso/Kconfig | 1 |
2 files changed, 10 insertions, 1 deletions
diff --git a/src/soc/amd/common/psp_verstage/psp_verstage.c b/src/soc/amd/common/psp_verstage/psp_verstage.c index 2265e17e09..5c59c4f4e4 100644 --- a/src/soc/amd/common/psp_verstage/psp_verstage.c +++ b/src/soc/amd/common/psp_verstage/psp_verstage.c @@ -238,6 +238,16 @@ void Main(void) reboot_into_recovery(ctx, retval); post_code(POSTCODE_UPDATE_BOOT_REGION); + + /* + * Since psp_verstage doesn't load next stage we never call + * any cbfs API on RO path. However we still need to initialize + * RO CBFS MCACHE manually to pass it in transfer_buffer. + * In RW path, MCACHE build will be skipped for RO region since + * we already built here. + */ + cbfs_get_boot_device(true); + retval = update_boot_region(ctx); if (retval) reboot_into_recovery(ctx, retval); diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index b93027734a..4bfd093d85 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -67,7 +67,6 @@ config CPU_SPECIFIC_OPTIONS select FSP_COMPRESS_FSP_S_LZMA select UDK_2017_BINDING select HAVE_CF9_RESET - select NO_CBFS_MCACHE if VBOOT_STARTS_BEFORE_BOOTBLOCK config SOC_AMD_COMMON_BLOCK_UCODE_SIZE default 3200 |