diff options
| author | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2023-10-24 17:06:18 -0500 |
|---|---|---|
| committer | Sean Rhodes <sean@starlabs.systems> | 2023-10-26 13:10:55 +0000 |
| commit | 434928c3a48188f68d333f4d03a758742bef66bf (patch) | |
| tree | 86b3995db416e897892bff794a43389b8d4d4192 /src | |
| parent | 10201aa99de8d78c6cea42a7222006165427d58a (diff) | |
mb/starlabs/*/Kconfig: Fix default power state after failure
POWER_STATE_OFF_AFTER_FAILURE can't be directly selected since it's a
choice, so instead set POWER_STATE_DEFAULT_ON_AFTER_FAILURE to n, as
it's functionally equivalent. This fixes the warnings generated by
the pre-commit hook Kconfig check.
It is necessary to override and set default n in the mainboard Kconfig
as it is set to default y in src/soc/intel/common/block/pmc/Kconfig.
TEST=select starlabs/starbook_adl in menuconfig and verify the default
power-on setting is S5/soft off.
Change-Id: I3ce33517dcc0af693b8db8d1de2926117ad3c16b
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78627
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Eric Lai <ericllai@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mainboard/starlabs/lite/Kconfig | 4 | ||||
| -rw-r--r-- | src/mainboard/starlabs/starbook/Kconfig | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/starlabs/lite/Kconfig b/src/mainboard/starlabs/lite/Kconfig index ee1958eec6..64926d976f 100644 --- a/src/mainboard/starlabs/lite/Kconfig +++ b/src/mainboard/starlabs/lite/Kconfig @@ -71,8 +71,8 @@ config MAINBOARD_SMBIOS_PRODUCT_NAME string default "Lite" -config POWER_STATE_OFF_AFTER_FAILURE - default y +config POWER_STATE_DEFAULT_ON_AFTER_FAILURE + default n config TRACKPAD_INTERRUPT hex diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 4cb04c3b3d..4d0ebe41ff 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -159,8 +159,8 @@ config ME_BIN_PATH default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/\$(CONFIG_VARIANT_DIR)/intel_me.bin" -config POWER_STATE_OFF_AFTER_FAILURE - default y +config POWER_STATE_DEFAULT_ON_AFTER_FAILURE + default n config EDK2_BOOTSPLASH_FILE string |