summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2022-06-19 18:08:31 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2022-06-22 08:56:31 +0000
commit37b161fb96c602765fef9f64415f809830b915a4 (patch)
tree66f01f66412e914157dacfc2f41e24cda48e3f39 /src
parenteae983161e923956a02136b3fbce707ff69ec1fa (diff)
intel/broadwell,lynxpoint: Change formula around 4 GiB
Let's not rely on the type to get the correct result, casting 0 to 0ull made the result wrong. Change-Id: I6dfba3800170fdd4267e3bb74c55b05533c101fc Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/65266 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src')
-rw-r--r--src/soc/intel/broadwell/pch/lpc.c2
-rw-r--r--src/southbridge/intel/lynxpoint/lpc.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/broadwell/pch/lpc.c b/src/soc/intel/broadwell/pch/lpc.c
index 45669b3987..5c4103d79a 100644
--- a/src/soc/intel/broadwell/pch/lpc.c
+++ b/src/soc/intel/broadwell/pch/lpc.c
@@ -470,7 +470,7 @@ static void pch_lpc_add_mmio_resources(struct device *dev)
*/
res = new_resource(dev, OIC);
res->base = default_decode_base;
- res->size = 0 - default_decode_base;
+ res->size = 4ull * GiB - default_decode_base;
res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
/* RCBA */
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index 73cf37f921..7ae847b79b 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -624,7 +624,7 @@ static void pch_lpc_add_mmio_resources(struct device *dev)
*/
res = new_resource(dev, OIC);
res->base = default_decode_base;
- res->size = 0 - default_decode_base;
+ res->size = 4ull * GiB - default_decode_base;
res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
/* RCBA */