diff options
| author | Terry Cheong <htcheong@chromium.org> | 2024-06-04 13:15:54 +0800 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-08-02 01:19:36 +0000 |
| commit | 3396c4027d3723a2f8693448f660748e2bb7c07f (patch) | |
| tree | f293766d34833223dfcb18797742da88baf6a5ad /src | |
| parent | ef4d562d2fb8e5ecc8c917adac809814194aa937 (diff) | |
mb/google/brox/var/brox: Enable Class-D calibration
DC offset of class-D amplifier is 7mV in Brox which is larger than the expected 3mV.
Add a section in the verb table to enable class-D calibration based
on the updated verb table provided by Realtek in b:342506575 comment#6.
This improves the offset to be less than 1mV.
BUG=b:342506575
BRANCH=main
TEST=Verify DC offset of speaker amplier output is less than 1mV with a multimeter when \
playing -100dB sine waves.
Change-Id: I776f5c24ce3c829cbd64840957c1431608cf2b85
Signed-off-by: Terry Cheong <htcheong@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82794
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shelley Chen <shchen@google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h index c0b0eb0733..7cf01c2554 100644 --- a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h +++ b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h @@ -9,7 +9,7 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x10ec0256, // Codec Vendor / Device ID: Realtek ALC256 0x10ec12ac, // Subsystem ID - 0x00000013, // Number of jacks (NID entries) + 0x00000014, // Number of jacks (NID entries) AZALIA_RESET(0x1), /* NID 0x01, HDA Codec Subsystem ID Verb table */ @@ -113,6 +113,11 @@ const u32 cim_verb_data[] = { 0x02046A0C, 0x02050008, 0x02046A0C, + /* Class-D calibration */ + 0x05850000, + 0x0584F880, + 0x05850000, + 0x0584F880, }; const u32 pc_beep_verbs[] = { |