diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-05-25 19:15:11 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-05-27 15:41:15 +0000 |
| commit | 2a29d4535036315ce62b0a6eba46b5de1d0778bb (patch) | |
| tree | 6bf4ff8ffadef3c7ea49c1ed39c3cd4989d15a80 /src | |
| parent | a30641295a1907aeef73f3a38677ef8ec94b6f85 (diff) | |
lib/hexdump: remove hexdump32 and use hexdump instead
hexdump and hexdump32 do similar things, but hexdump32 is mostly a
reimplementation that has additional support to configure the console
log level, but has a very unexpected len parameter that isn't in bytes,
but in DWORDs.
With the move to hexdump() the console log level for the hexdump is
changed to BIOS_DEBUG.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6138d17f0ce8e4a14f22d132bf5c64d0c343b80d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/54925
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/include/lib.h | 1 | ||||
| -rw-r--r-- | src/lib/hexdump.c | 18 | ||||
| -rw-r--r-- | src/northbridge/intel/sandybridge/raminit_mrc.c | 2 |
3 files changed, 1 insertions, 20 deletions
diff --git a/src/include/lib.h b/src/include/lib.h index 359626c964..8e8bab55c1 100644 --- a/src/include/lib.h +++ b/src/include/lib.h @@ -29,7 +29,6 @@ int checkstack(void *top_of_stack, int core); * https://packages.debian.org/jessie/amd64/vim-common/filelist */ void hexdump(const void *memory, size_t length); -void hexdump32(char LEVEL, const void *d, size_t len); /* * hexstrtobin - Turn a string of ASCII hex characters into binary diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c index 90446c1481..533411f6f6 100644 --- a/src/lib/hexdump.c +++ b/src/lib/hexdump.c @@ -48,21 +48,3 @@ void hexdump(const void *memory, size_t length) } } } - -void hexdump32(char LEVEL, const void *d, size_t len) -{ - size_t count = 0; - - while (len > 0) { - if (count % 8 == 0) { - printk(LEVEL, "\n"); - printk(LEVEL, "%p:", d); - } - printk(LEVEL, " 0x%08lx", *(unsigned long *)d); - count++; - len--; - d += 4; - } - - printk(LEVEL, "\n\n"); -} diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index 21de0b2ea4..43619cd592 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -371,7 +371,7 @@ void perform_raminit(int s3resume) } else { printk(BIOS_ERR, "Could not parse MRC_VAR data\n"); - hexdump32(BIOS_ERR, mrc_var, sizeof(*mrc_var) / sizeof(u32)); + hexdump(mrc_var, sizeof(*mrc_var)); } const int cbmem_was_initted = !cbmem_recovery(s3resume); |