summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-11-23 07:23:40 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-06-03 13:31:56 +0000
commit0ef6562656acd04125fb2b8484d44277f173b1b0 (patch)
tree7ace32356a2b27965e81782229291ef3371dc686 /src
parent954a4a4d168caf264e6275deff5523d2863bdb19 (diff)
soc,southbridge/amd: Remove some explicit zero-initializers
Change-Id: I263c159fe4b7757dd5abfc0d6248e45b749df980 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/41908 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/soc/amd/picasso/acpi.c10
-rw-r--r--src/soc/amd/stoneyridge/acpi.c10
-rw-r--r--src/southbridge/amd/agesa/hudson/fadt.c10
-rw-r--r--src/southbridge/amd/cimx/sb800/fadt.c6
-rw-r--r--src/southbridge/amd/pi/hudson/fadt.c10
5 files changed, 0 insertions, 46 deletions
diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c
index 2eea6f9aeb..d5a890b6e3 100644
--- a/src/soc/amd/picasso/acpi.c
+++ b/src/soc/amd/picasso/acpi.c
@@ -111,16 +111,6 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->smi_cmd = APM_CNT;
fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
- fadt->s4bios_req = 0; /* Not supported */
- fadt->pstate_cnt = 0; /* Not supported */
- fadt->cst_cnt = 0; /* Not supported */
- } else {
- fadt->smi_cmd = 0; /* disable system management mode */
- fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
- fadt->acpi_disable = 0; /* unused if SMI_CMD = 0 */
- fadt->s4bios_req = 0; /* unused if SMI_CMD = 0 */
- fadt->pstate_cnt = 0; /* unused if SMI_CMD = 0 */
- fadt->cst_cnt = 0x00; /* unused if SMI_CMD = 0 */
}
fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c
index c98a1b4aca..47d12bf986 100644
--- a/src/soc/amd/stoneyridge/acpi.c
+++ b/src/soc/amd/stoneyridge/acpi.c
@@ -83,16 +83,6 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->smi_cmd = APM_CNT;
fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
- fadt->s4bios_req = 0; /* Not supported */
- fadt->pstate_cnt = 0; /* Not supported */
- fadt->cst_cnt = 0; /* Not supported */
- } else {
- fadt->smi_cmd = 0; /* disable system management mode */
- fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
- fadt->acpi_disable = 0; /* unused if SMI_CMD = 0 */
- fadt->s4bios_req = 0; /* unused if SMI_CMD = 0 */
- fadt->pstate_cnt = 0; /* unused if SMI_CMD = 0 */
- fadt->cst_cnt = 0x00; /* unused if SMI_CMD = 0 */
}
fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c
index 0476057b19..660598a0f9 100644
--- a/src/southbridge/amd/agesa/hudson/fadt.c
+++ b/src/southbridge/amd/agesa/hudson/fadt.c
@@ -61,16 +61,6 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
fadt->smi_cmd = ACPI_SMI_CTL_PORT;
fadt->acpi_enable = ACPI_SMI_CMD_ENABLE;
fadt->acpi_disable = ACPI_SMI_CMD_DISABLE;
- fadt->s4bios_req = 0; /* Not supported */
- fadt->pstate_cnt = 0; /* Not supported */
- fadt->cst_cnt = 0; /* Not supported */
- } else {
- fadt->smi_cmd = 0; /* disable system management mode */
- fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
- fadt->acpi_disable = 0; /* unused if SMI_CMD = 0 */
- fadt->s4bios_req = 0; /* unused if SMI_CMD = 0 */
- fadt->pstate_cnt = 0; /* unused if SMI_CMD = 0 */
- fadt->cst_cnt = 0x00; /* unused if SMI_CMD = 0 */
}
fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c
index 1939bac31e..d2339c6e00 100644
--- a/src/southbridge/amd/cimx/sb800/fadt.c
+++ b/src/southbridge/amd/cimx/sb800/fadt.c
@@ -61,11 +61,6 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
fadt->reserved = 0; /* reserved, should be 0 ACPI 3.0 */
fadt->preferred_pm_profile = FADT_PM_PROFILE;
fadt->sci_int = 9; /* HUDSON 1 - IRQ 09 - ACPI SCI */
- fadt->smi_cmd = 0; /* disable system management mode */
- fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
- fadt->acpi_disable = 0; /* unused if SMI_CMD = 0 */
- fadt->s4bios_req = 0; /* unused if SMI_CMD = 0 */
- fadt->pstate_cnt = 0; /* unused if SMI_CMD = 0 */
val = PM1_EVT_BLK_ADDRESS;
WritePMIO(SB_PMIOA_REG60, AccWidthUint16, &val);
@@ -109,7 +104,6 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
fadt->gpe1_blk_len = 0;
fadt->gpe1_base = 0;
- fadt->cst_cnt = 0x00; /* unused if SMI_CMD = 0 */
fadt->p_lvl2_lat = ACPI_FADT_C2_NOT_SUPPORTED;
fadt->p_lvl3_lat = ACPI_FADT_C3_NOT_SUPPORTED;
fadt->flush_size = 0; /* set to 0 if WBINVD is 1 in flags */
diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c
index d45be9af4b..100cfb6ac4 100644
--- a/src/southbridge/amd/pi/hudson/fadt.c
+++ b/src/southbridge/amd/pi/hudson/fadt.c
@@ -53,16 +53,6 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
fadt->smi_cmd = ACPI_SMI_CTL_PORT;
fadt->acpi_enable = ACPI_SMI_CMD_ENABLE;
fadt->acpi_disable = ACPI_SMI_CMD_DISABLE;
- fadt->s4bios_req = 0; /* Not supported */
- fadt->pstate_cnt = 0; /* Not supported */
- fadt->cst_cnt = 0; /* Not supported */
- } else {
- fadt->smi_cmd = 0; /* disable system management mode */
- fadt->acpi_enable = 0; /* unused if SMI_CMD = 0 */
- fadt->acpi_disable = 0; /* unused if SMI_CMD = 0 */
- fadt->s4bios_req = 0; /* unused if SMI_CMD = 0 */
- fadt->pstate_cnt = 0; /* unused if SMI_CMD = 0 */
- fadt->cst_cnt = 0x00; /* unused if SMI_CMD = 0 */
}
fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-22 10:26:41 +0000