summaryrefslogtreecommitdiff
path: root/src/vendorcode/amd/pi/00670F00
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2018-06-28 22:12:20 +0300
committerPatrick Georgi <pgeorgi@google.com>2019-04-23 10:10:45 +0000
commit63bc18e3285bf00d3239d89bc0c4cad97cbbc383 (patch)
tree2ca182ca835679d1abf3d26b50e331fa4b4c1f6e /src/vendorcode/amd/pi/00670F00
parent6e512c4d7a4faa68bf64b37c68bae8141d9e4518 (diff)
soc/amd/common: Remove AmdReadEventLog()
Parameter passing is incorrect here, it should pass complete StdHeader instead of attempting to fill in HeapStatus that should be treated as a field private to AGESA, based on where it is defined in the header files. Furthermore the while() loop did not evaluate the return value. Feature can be brought back at a later date after someone verifies it actually works correctly across different stages. Change-Id: Ib243b275f8700ecaeb330772c795d305c61899c5 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/31484 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/vendorcode/amd/pi/00670F00')
-rw-r--r--src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c14
1 files changed, 0 insertions, 14 deletions
diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index c42df59bd4..2efee4eb62 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -226,17 +226,3 @@ AmdLateRunApTask (
if (!Dispatcher) return AGESA_UNSUPPORTED;
return Dispatcher(AmdApExeParams);
}
-
-/**********************************************************************
- * Interface service call: AmdReadEventLog
- **********************************************************************/
-AGESA_STATUS
-AmdReadEventLog (
- IN EVENT_PARAMS *Event
-)
-{
- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
- Event->StdHeader.Func = AMD_READ_EVENT_LOG;
- if (!Dispatcher) return AGESA_UNSUPPORTED;
- return Dispatcher(Event);
-}