summaryrefslogtreecommitdiff
path: root/src/vendorcode/amd/opensil/genoa_poc
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2024-03-18 21:19:45 +0100
committerFelix Held <felix-coreboot@felixheld.de>2024-03-22 21:50:03 +0000
commite261aa0aa7adbed0d9dec51a6d4bac2594149ca4 (patch)
tree2a8f595ccd80ca48142b4de681c5c297984378fe /src/vendorcode/amd/opensil/genoa_poc
parent4b187551d202039189c2f81b56836409c002f23d (diff)
vc/amd/opensil/genoa_poc/mpio: simplify per_device_config arguments
Since we're already passing a pointer to the corresponding device to per_device_config, we don't need to pass the chip_info as separate parameter. Before moving the PCIe port function device below the MPIO chip, the chip_info struct was from a different device, so that change allows this simplification. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I0466f7ad2f5c9874d45712fa9f89b978bd2a09bc Reviewed-on: https://review.coreboot.org/c/coreboot/+/81341 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
Diffstat (limited to 'src/vendorcode/amd/opensil/genoa_poc')
-rw-r--r--src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
index 6d811ce47d..cae9d4b8e7 100644
--- a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
+++ b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
@@ -125,12 +125,12 @@ static void setup_bmc_lanes(uint8_t lane, uint8_t socket)
mpio_data->EarlyBmcLinkDie = 0;
}
-static void per_device_config(MPIOCLASS_INPUT_BLK *mpio_data, struct device *dev,
- struct vendorcode_amd_opensil_genoa_poc_mpio_config *const config)
+static void per_device_config(MPIOCLASS_INPUT_BLK *mpio_data, struct device *dev)
{
static uint32_t slot_num;
const uint32_t domain = dev->upstream->dev->path.domain.domain;
const uint32_t devfn = dev->path.pci.devfn;
+ const struct vendorcode_amd_opensil_genoa_poc_mpio_config *const config = dev->chip_info;
printk(BIOS_DEBUG, "Setting MPIO port for domain 0x%x, PCI %d:%d\n",
domain, PCI_SLOT(devfn), PCI_FUNC(devfn));
@@ -198,5 +198,5 @@ void configure_mpio(void)
for (struct device *dev = &dev_root; dev; dev = dev->next)
if (dev->chip_ops == &vendorcode_amd_opensil_genoa_poc_mpio_ops &&
dev->chip_info != dev->upstream->dev->chip_info)
- per_device_config(mpio_data, dev, dev->chip_info);
+ per_device_config(mpio_data, dev);
}