diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-05-21 09:42:56 +1000 |
|---|---|---|
| committer | Marc Jones <marc.jones@se-eng.com> | 2014-05-21 01:58:56 +0200 |
| commit | 8a661ed788ff1373015a5c6b705e2e32b63ebe4a (patch) | |
| tree | 194c9b63601d3eccea99f421840352a543bf28bd /src/vendorcode/amd/cimx/sb700 | |
| parent | 03b00e9675d08d01ff831f20e8e48d19e93494af (diff) | |
amd/cimx/sb?00/SATA.c: Integer overflow in loop condition
The conditional comparison in the for-loop construct with the constant
300000 has an index incrementor of type 'UINT16' (aka 'unsigned short')
which is always true.
Change-Id: I932c168742163be4038728fb40833231a447fa78
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5799
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
Diffstat (limited to 'src/vendorcode/amd/cimx/sb700')
| -rw-r--r-- | src/vendorcode/amd/cimx/sb700/SATA.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vendorcode/amd/cimx/sb700/SATA.c b/src/vendorcode/amd/cimx/sb700/SATA.c index 09d49237ea..d5032397fe 100644 --- a/src/vendorcode/amd/cimx/sb700/SATA.c +++ b/src/vendorcode/amd/cimx/sb700/SATA.c @@ -238,7 +238,7 @@ void sataInitAfterPciEnum(AMDSBCFG* pConfig){ void sataDriveDetection(AMDSBCFG* pConfig, UINT32 ddBar5){ UINT32 ddVar0; UINT8 dbPortNum, dbVar0; - UINT16 dwIoBase, dwVar0; + UINT32 dwIoBase, dwVar0; TRACE((DMSG_SB_TRACE, "CIMx - Entering sata drive detection procedure\n\n")); TRACE((DMSG_SB_TRACE, "SATA BAR5 is %X \n", ddBar5)); |