diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-07-07 21:08:23 +1000 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-07-18 07:20:16 +0200 |
| commit | cd47560f2ae0758012001d6d954653b4526811ad (patch) | |
| tree | 3dc23e7f9960f152f0492e9d5b49b45d9e9e91e9 /src/vendorcode/amd/agesa/f16kb | |
| parent | 53584fa32f18eafa1f71be511f20d388550b918b (diff) | |
vendorcode/amd/agesa: Use macros already defined in stdlib.h
We already have these macros define in 'stdlib.h'. Make good use of them
here to avoid redefinition conflicts of the pre-processor depending on
header inclusion ordering. This has the nice side-effect of syncing up
AGESA families in this particular regard.
Change-Id: Icf911629a4a1a82b01062fe16af4c8f812b05717
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6199
Tested-by: build bot (Jenkins)
Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
Diffstat (limited to 'src/vendorcode/amd/agesa/f16kb')
| -rw-r--r-- | src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h | 10 | ||||
| -rw-r--r-- | src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h | 31 |
2 files changed, 3 insertions, 38 deletions
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h index 100ae03036..c01fd5ef98 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h +++ b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h @@ -45,6 +45,8 @@ #ifndef _GNB_H_ #define _GNB_H_ +#include <stdlib.h> + #include "Ids.h" #pragma pack (push, 1) @@ -71,14 +73,6 @@ #endif #endif -#ifndef MIN - #define MIN(x, y) (((x) > (y))? (y):(x)) -#endif - -#ifndef MAX - #define MAX(x, y) (((x) > (y))? (x):(y)) -#endif - #define OFF 0 #define PVOID UINT32 diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h index 1489fe8b5a..f415e524e0 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h @@ -60,36 +60,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#ifndef MAX - #define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -#endif -// -// Minimum Value macro -// -#ifndef MIN - #define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -#endif -// -// Absolute Value Macro -// -#ifndef ABS - #define ABS(X) (((X) < 0) ? (-(X)) : (X)) -#endif -// -// Taking ceiling of (a / b) -// -#ifndef CEIL_DIV - #define CEIL_DIV(a, b) (((a) + (b) - 1) / (b)) -#endif -// -// Check if value x is a power of 2 or not -// -#ifndef IS_POWER_OF_2 - #define IS_POWER_OF_2(x) (((x) & ((x) - 1)) == 0) -#endif +#include <stdlib.h> // // Find offset of a member variable in a struct // |