diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-08-07 20:12:36 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-08-11 23:11:57 +0000 |
| commit | d53137a536ff010efd0af26bb7728ff8684ec0a1 (patch) | |
| tree | 28d40c986153f86e4c9ec677d30b66f7db4c40fd /src/superio | |
| parent | e566e1547b0ac7be36e87b6a629355b80241250b (diff) | |
superio/smsc/sch5147/acpi/superio: use IO instead of FixedIO resource
The fixed I/O resource descriptor macro implies that the device will
only decode 10 of the 16 IO port bits causing aliasing. Use an I/O port
descriptor instead and use Decode16 to tell the OS that this I/O
resource will decode all I/O address bits.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I2df260cea6f12f5a3a6cbae3c7b99bab244a556b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77066
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Diffstat (limited to 'src/superio')
| -rw-r--r-- | src/superio/smsc/sch5147/acpi/superio.asl | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/superio/smsc/sch5147/acpi/superio.asl b/src/superio/smsc/sch5147/acpi/superio.asl index d5040e73b5..41988e3eac 100644 --- a/src/superio/smsc/sch5147/acpi/superio.asl +++ b/src/superio/smsc/sch5147/acpi/superio.asl @@ -74,7 +74,7 @@ Device(SUPERIO_DEV) { { /* Announce the used i/o ports to the OS */ Return (ResourceTemplate () { - FixedIO (SUPERIO_PNP_BASE, 0x02) + IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02) }) } @@ -140,8 +140,8 @@ Device (SUPERIO_ID(KBD, SUPERIO_KBC_LDN)) { Method (_CRS, 0, Serialized) { Name (CRS, ResourceTemplate () { - FixedIO (0x0060, 0x01) - FixedIO (0x0064, 0x01) + IO (Decode16, 0x0060, 0x0060, 0x01, 0x01) + IO (Decode16, 0x0064, 0x0064, 0x01, 0x01) IRQNoFlags (IR0) {} }) ENTER_CONFIG_MODE (SUPERIO_KBC_LDN) @@ -153,8 +153,8 @@ Device (SUPERIO_ID(KBD, SUPERIO_KBC_LDN)) { Name (_PRS, ResourceTemplate () { StartDependentFn (0,0) { - FixedIO (0x0060, 0x01) - FixedIO (0x0064, 0x01) + IO (Decode16, 0x0060, 0x0060, 0x01, 0x01) + IO (Decode16, 0x0064, 0x0064, 0x01, 0x01) IRQNoFlags () {1} } EndDependentFn() @@ -163,8 +163,8 @@ Device (SUPERIO_ID(KBD, SUPERIO_KBC_LDN)) { Method (_SRS, 1, Serialized) { Name (TMPL, ResourceTemplate () { - FixedIO (0x0060, 0x01) - FixedIO (0x0064, 0x01) + IO (Decode16, 0x0060, 0x0060, 0x01, 0x01) + IO (Decode16, 0x0064, 0x0064, 0x01, 0x01) IRQNoFlags (IR0) {} }) ENTER_CONFIG_MODE (SUPERIO_KBC_LDN) |