diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2017-12-27 22:11:30 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2018-07-18 18:49:40 +0000 |
| commit | c40275bce0efb8b79792c7a6f846204b4c317124 (patch) | |
| tree | e8f81f5970721ddc93b759d5374708de58ba9867 /src/superio/ite/it8718f | |
| parent | 3a59174cf02c8c0afd8eb547f5325788cd3537ea (diff) | |
superio/ite: pass the chip-specific ops struct to pnp_enable_devices
Pass the address of the chip-specific ops struct instead of the one of the
generic pnp_ops struct to the PNP device enable function.
This allows the removal of the LDN-specific ops overrides which is also done in
this patch.
Change-Id: I5f03a4064778c419f4b9c50e70db1296addf6c9e
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/23006
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/superio/ite/it8718f')
| -rw-r--r-- | src/superio/ite/it8718f/superio.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c index ca2fedb6d3..ed15955426 100644 --- a/src/superio/ite/it8718f/superio.c +++ b/src/superio/ite/it8718f/superio.c @@ -65,25 +65,24 @@ static struct device_operations ops = { /* TODO: IR. */ static struct pnp_info pnp_dev_info[] = { - { &ops, IT8718F_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0 + { NULL, IT8718F_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0 | PNP_MSC0 | PNP_MSC1, 0x0ff8, }, - { &ops, IT8718F_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { &ops, IT8718F_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { &ops, IT8718F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 + { NULL, IT8718F_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8, }, + { NULL, IT8718F_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, + { NULL, IT8718F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_MSC0 | PNP_MSC1 | PNP_MSC2 | PNP_MSC3 | PNP_MSC4 | PNP_MSC5 | PNP_MSC6, 0x0ff8, 0x0ff8, }, - { &ops, IT8718F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0 + { NULL, IT8718F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_MSC0, 0x07f8, 0x07f8, }, - { &ops, IT8718F_KBCM, PNP_IRQ0 | PNP_MSC0, }, - { &ops, IT8718F_PP, PNP_IO0 | PNP_IO1 | PNP_IRQ0 + { NULL, IT8718F_KBCM, PNP_IRQ0 | PNP_MSC0, }, + { NULL, IT8718F_PP, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_DRQ0 | PNP_MSC0, 0x0ff8, 0x0ff8, }, }; static void enable_dev(struct device *dev) { - pnp_enable_devices(dev, &pnp_ops, - ARRAY_SIZE(pnp_dev_info), pnp_dev_info); + pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } struct chip_operations superio_ite_it8718f_ops = { |