diff options
| author | Elyes Haouas <ehaouas@noos.fr> | 2022-12-06 11:58:52 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-12-12 18:20:55 +0000 |
| commit | 8f53e20955c7245861d3ad1a5ab29bc2d62c358d (patch) | |
| tree | 7b1d0da394d5fa8190b52319593fb4f61358ca5f /src/southbridge | |
| parent | 9d1c9ee2121171f38d651ef4ffa8f7eef274b41d (diff) | |
sb/intel/common/acpi_pirq_gen.h: Fix conflicting types for 'is_slot_pin_assigned'
Found using 'Wenum-int-mismatch' (GCC-13: default with -Wall):
src/southbridge/intel/common/acpi_pirq_gen.c:69:6: error: conflicting types for 'is_slot_pin_assigned' due to enum/integer mismatch; have 'bool(const struct slot_pin_irq_map *, unsigned int, unsigned int, enum pci_pin)' {aka '_Bool(const struct slot_pin_irq_map *, unsigned int, unsigned int, enum pci_pin)'} [-Werror=enum-int-mismatch]
69 | bool is_slot_pin_assigned(const struct slot_pin_irq_map *pin_irq_map,
| ^~~~~~~~~~~~~~~~~~~~
In file included from src/southbridge/intel/common/acpi_pirq_gen.c:8:
src/southbridge/intel/common/acpi_pirq_gen.h:91:6: note: previous declaration of 'is_slot_pin_assigned' with type 'bool(const struct slot_pin_irq_map *, unsigned int, unsigned int, unsigned int)' {aka '_Bool(const struct slot_pin_irq_map *, unsigned int, unsigned int, unsigned int)'}
91 | bool is_slot_pin_assigned(const struct slot_pin_irq_map *pin_irq_map,
| ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Change-Id: Ie91947d00feaae42314ec2d1291f39d667a85346
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70387
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <inforichland@gmail.com>
Diffstat (limited to 'src/southbridge')
| -rw-r--r-- | src/southbridge/intel/common/acpi_pirq_gen.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/southbridge/intel/common/acpi_pirq_gen.h b/src/southbridge/intel/common/acpi_pirq_gen.h index 4799528fcc..36e432e31c 100644 --- a/src/southbridge/intel/common/acpi_pirq_gen.h +++ b/src/southbridge/intel/common/acpi_pirq_gen.h @@ -89,6 +89,7 @@ void intel_write_pci0_PRT(const struct slot_pin_irq_map *pin_irq_map, const struct pic_pirq_map *pirq_map); bool is_slot_pin_assigned(const struct slot_pin_irq_map *pin_irq_map, - unsigned int map_count, unsigned int slot, unsigned int pin); + unsigned int map_count, unsigned int slot, + enum pci_pin pin); #endif |