diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2015-10-05 08:00:51 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-12-30 18:34:08 +0100 |
| commit | 8a13743569a8d1ac61b8a52d2dab621ff4041de2 (patch) | |
| tree | 4ee4ef61e8aab9d8ac72ad17390ae8c7c35350cb /src/southbridge/nvidia | |
| parent | acc94a73bab2ede4e876e58c2de53ee0551f703c (diff) | |
x86 chipsets: Link non-code flow CHIPSET_BOOTBLOCK_INCLUDE files
Non-code flow assembly stubs do not have to be included in
bootblock.S, now that we have more freedom in bootblock linking.
Rather than bringing these stubs to the config system, just link them
in the bootblock.
Note that we cannot fully remove CHIPSET_BOOTBLOCK_INCLUDE at this
point, as some intel SOCs use this stub for code flow.
objdump -h build/cbfs/fallback/bootblock.debug on a few random boards
confirms that the appropriate sections are still included in the
final binary.
Change-Id: Id3f9ece14e399c1cc83090f407780c4a05a076f0
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: https://review.coreboot.org/11856
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/southbridge/nvidia')
| -rw-r--r-- | src/southbridge/nvidia/ck804/Kconfig | 4 | ||||
| -rw-r--r-- | src/southbridge/nvidia/ck804/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/southbridge/nvidia/ck804/romstrap.S (renamed from src/southbridge/nvidia/ck804/romstrap.inc) | 0 | ||||
| -rw-r--r-- | src/southbridge/nvidia/mcp55/Kconfig | 4 | ||||
| -rw-r--r-- | src/southbridge/nvidia/mcp55/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/southbridge/nvidia/mcp55/romstrap.S (renamed from src/southbridge/nvidia/mcp55/romstrap.inc) | 0 |
6 files changed, 2 insertions, 8 deletions
diff --git a/src/southbridge/nvidia/ck804/Kconfig b/src/southbridge/nvidia/ck804/Kconfig index 42dce07b14..dbd24b73d1 100644 --- a/src/southbridge/nvidia/ck804/Kconfig +++ b/src/southbridge/nvidia/ck804/Kconfig @@ -42,8 +42,4 @@ config HPET_MIN_TICKS hex default 0xfa -config CHIPSET_BOOTBLOCK_INCLUDE - string - default "southbridge/nvidia/ck804/romstrap.inc" - endif diff --git a/src/southbridge/nvidia/ck804/Makefile.inc b/src/southbridge/nvidia/ck804/Makefile.inc index 69dd4b271e..554a4407f0 100644 --- a/src/southbridge/nvidia/ck804/Makefile.inc +++ b/src/southbridge/nvidia/ck804/Makefile.inc @@ -22,5 +22,6 @@ ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c romstage-y += early_smbus.c bootblock-y += romstrap.ld +bootblock-y += romstrap.S endif diff --git a/src/southbridge/nvidia/ck804/romstrap.inc b/src/southbridge/nvidia/ck804/romstrap.S index 5a20107376..5a20107376 100644 --- a/src/southbridge/nvidia/ck804/romstrap.inc +++ b/src/southbridge/nvidia/ck804/romstrap.S diff --git a/src/southbridge/nvidia/mcp55/Kconfig b/src/southbridge/nvidia/mcp55/Kconfig index 666d3f8962..89aa45258a 100644 --- a/src/southbridge/nvidia/mcp55/Kconfig +++ b/src/southbridge/nvidia/mcp55/Kconfig @@ -42,8 +42,4 @@ config MCP55_PCI_E_X_3 int default 4 -config CHIPSET_BOOTBLOCK_INCLUDE - string - default "southbridge/nvidia/mcp55/romstrap.inc" - endif diff --git a/src/southbridge/nvidia/mcp55/Makefile.inc b/src/southbridge/nvidia/mcp55/Makefile.inc index 74ef14cdbc..db275cc848 100644 --- a/src/southbridge/nvidia/mcp55/Makefile.inc +++ b/src/southbridge/nvidia/mcp55/Makefile.inc @@ -25,5 +25,6 @@ ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c endif bootblock-y += romstrap.ld +bootblock-y += romstrap.S endif diff --git a/src/southbridge/nvidia/mcp55/romstrap.inc b/src/southbridge/nvidia/mcp55/romstrap.S index ff170a9927..ff170a9927 100644 --- a/src/southbridge/nvidia/mcp55/romstrap.inc +++ b/src/southbridge/nvidia/mcp55/romstrap.S |