diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2024-06-10 13:35:03 -0500 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-06-11 18:59:24 +0000 |
| commit | bdd3b00926162f2535813f44bc591eba2d353c82 (patch) | |
| tree | fe0512de0f3835363b97ddd7498d66fa19e73dcd /src/southbridge/intel | |
| parent | 6a673d46eefe78c5c5698aa395238b746edf37eb (diff) | |
sb/intel/lynxpoint/fadt: Fill extended FADT after populating lengths
Commit 88decca14f84 ("ACPI: Add helper fill_fadt_extended_pm_io()")
moved the population of the extended FADT to a separate function, but
incorrectly placed that function call before various length fields were
populated, leading to spurious validation errors in the cbmem boot log.
Correct this by moving the call to fill_fadt_extended_pm_io() after
the required fields are populated.
TEST=build/boot google/slippy (wolf), verify no FADT errors in cbmem
console log.
Change-Id: I1f8522e4813e6071692206f2b7ad2a2f5086071e
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83035
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/southbridge/intel')
| -rw-r--r-- | src/southbridge/intel/lynxpoint/fadt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/southbridge/intel/lynxpoint/fadt.c b/src/southbridge/intel/lynxpoint/fadt.c index ea542cac15..2eec269ee0 100644 --- a/src/southbridge/intel/lynxpoint/fadt.c +++ b/src/southbridge/intel/lynxpoint/fadt.c @@ -21,8 +21,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) else fadt->gpe0_blk = pmbase + GPE0_STS; - fill_fadt_extended_pm_io(fadt); - /* * Some of the lengths here are doubled. This is because they describe * blocks containing two registers, where the size of each register @@ -38,6 +36,8 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) else fadt->gpe0_blk_len = 2 * 8; + fill_fadt_extended_pm_io(fadt); + fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042; fadt->flags |= ACPI_FADT_WBINVD | |