summaryrefslogtreecommitdiff
path: root/src/southbridge/intel
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2022-12-03 19:35:53 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2022-12-07 04:50:40 +0000
commita0720431b4c0685634fd1ccc45938e9b3cc40544 (patch)
tree36598141dce48d44a948fed2ded8d75534b06337 /src/southbridge/intel
parent7a9bd2b2e4a2c0be9f9ecc04e47684639973baef (diff)
sb,soc/intel: Fix SMI handler IO trap data mask
Shift is done in multiples of 8 (1 << 3) bits. It was fixed already for i82801ix/jx. Change-Id: I5e1c2b3bf4ba68f34eb43e59fe783d5cd6e0a39a Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70361 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/southbridge/intel')
-rw-r--r--src/southbridge/intel/bd82x6x/smihandler.c2
-rw-r--r--src/southbridge/intel/i82801gx/smihandler.c2
-rw-r--r--src/southbridge/intel/ibexpeak/smihandler.c2
-rw-r--r--src/southbridge/intel/lynxpoint/smihandler.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c
index bf03b1a51d..351751ec4b 100644
--- a/src/southbridge/intel/bd82x6x/smihandler.c
+++ b/src/southbridge/intel/bd82x6x/smihandler.c
@@ -100,7 +100,7 @@ void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10);
for (i=16; i<20; i++) {
if (trap_cycle & (1 << i))
- mask |= (0xff << ((i - 16) << 2));
+ mask |= (0xff << ((i - 16) << 3));
}
/* IOTRAP(3) SMI function call */
diff --git a/src/southbridge/intel/i82801gx/smihandler.c b/src/southbridge/intel/i82801gx/smihandler.c
index 67a8cf8cf4..9fbca38e9d 100644
--- a/src/southbridge/intel/i82801gx/smihandler.c
+++ b/src/southbridge/intel/i82801gx/smihandler.c
@@ -49,7 +49,7 @@ void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10);
for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i))
- mask |= (0xff << ((i - 16) << 2));
+ mask |= (0xff << ((i - 16) << 3));
}
/* IOTRAP(3) SMI function call */
diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c
index 5fb3077053..81dde32499 100644
--- a/src/southbridge/intel/ibexpeak/smihandler.c
+++ b/src/southbridge/intel/ibexpeak/smihandler.c
@@ -85,7 +85,7 @@ void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10);
for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i))
- mask |= (0xff << ((i - 16) << 2));
+ mask |= (0xff << ((i - 16) << 3));
}
/* IOTRAP(3) SMI function call */
diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c
index 769cacb792..52c9a000d3 100644
--- a/src/southbridge/intel/lynxpoint/smihandler.c
+++ b/src/southbridge/intel/lynxpoint/smihandler.c
@@ -393,7 +393,7 @@ static void southbridge_smi_monitor(void)
trap_cycle = RCBA32(0x1e10);
for (i = 16; i < 20; i++) {
if (trap_cycle & (1 << i))
- mask |= (0xff << ((i - 16) << 2));
+ mask |= (0xff << ((i - 16) << 3));
}
/* IOTRAP(3) SMI function call */