diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-04-19 13:15:28 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-04-21 09:00:18 +0000 |
| commit | 62719a379776efdde3439f053363170133fd8e69 (patch) | |
| tree | c091d47e9b9cc26a2b7ee19bfffebb728e7253d9 /src/southbridge/intel/lynxpoint | |
| parent | 5daa412939bfb35cec7a876d68860fe0f4bb9515 (diff) | |
{sb,soc}/intel: Use `get_int_option` function
Change-Id: I05f724785880089a513319d70dfd70fc2a6b7679
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47109
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src/southbridge/intel/lynxpoint')
| -rw-r--r-- | src/southbridge/intel/lynxpoint/lpc.c | 8 | ||||
| -rw-r--r-- | src/southbridge/intel/lynxpoint/smihandler.c | 5 |
2 files changed, 5 insertions, 8 deletions
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index 55157a8d54..71e4d74602 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -185,8 +185,6 @@ static void pch_power_options(struct device *dev) u32 reg32; const char *state; u16 pmbase = get_pmbase(); - int pwr_on = CONFIG_MAINBOARD_POWER_FAILURE_STATE; - int nmi_option; /* Which state do we want to goto after g3 (power restored)? * 0 == S0 Full On @@ -194,7 +192,8 @@ static void pch_power_options(struct device *dev) * * If the option is not existent (Laptops), use Kconfig setting. */ - get_option(&pwr_on, "power_on_after_fail"); + const int pwr_on = get_int_option("power_on_after_fail", + CONFIG_MAINBOARD_POWER_FAILURE_STATE); reg16 = pci_read_config16(dev, GEN_PMCON_3); reg16 &= 0xfffe; @@ -235,8 +234,7 @@ static void pch_power_options(struct device *dev) outb(reg8, 0x61); reg8 = inb(0x70); - nmi_option = NMI_OFF; - get_option(&nmi_option, "nmi"); + const int nmi_option = get_int_option("nmi", NMI_OFF); if (nmi_option) { printk(BIOS_INFO, "NMI sources enabled.\n"); reg8 &= ~(1 << 7); /* Set NMI. */ diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index 9c7b269c1f..2c89a9538e 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -78,13 +78,12 @@ static void busmaster_disable_on_bus(int bus) static int power_on_after_fail(void) { - u8 s5pwr = CONFIG_MAINBOARD_POWER_FAILURE_STATE; - /* save and recover RTC port values */ u8 tmp70, tmp72; tmp70 = inb(0x70); tmp72 = inb(0x72); - get_option(&s5pwr, "power_on_after_fail"); + const int s5pwr = get_int_option("power_on_after_fail", + CONFIG_MAINBOARD_POWER_FAILURE_STATE); outb(tmp70, 0x70); outb(tmp72, 0x72); |