diff options
| author | Kane Chen <kane.chen@intel.corp-partner.google.com> | 2022-05-12 16:58:38 +0800 |
|---|---|---|
| committer | Werner Zeh <werner.zeh@siemens.com> | 2022-05-16 05:14:51 +0000 |
| commit | be9cef9468169dbb7316cf5c96b9b372e1c94a91 (patch) | |
| tree | ee46f6ba6b06e35bf4c45a847c856407206fce0e /src/soc | |
| parent | 0485ab6612b0030b808331b48903c94bc97ce653 (diff) | |
soc/intel/common: Consistently use smbus 7-bit address log format
The "No memory dimm at address" line in get_spd_sn and get_spd fucntion
have different format of SPD address.
get_spd_sn shows a 8-bit address format but get_spd shows a 7-bit
address format when there is no DIMM connected. It can be confusing
when debugging.
Change-Id: I46a006f4024b12d27ae0a933b7c40515034d5d64
Signed-off-by: Kane Chen <kane.chen@intel.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64290
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jamie Chen <jamie.chen@intel.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/intel/common/block/smbus/smbuslib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c index 17b63774de..a92f88018c 100644 --- a/src/soc/intel/common/block/smbus/smbuslib.c +++ b/src/soc/intel/common/block/smbus/smbuslib.c @@ -105,7 +105,7 @@ enum cb_err get_spd_sn(u8 addr, u32 *sn) /* If dimm is not present, set sn to 0xff. */ smbus_ret = smbus_read_byte(addr, SPD_DRAM_TYPE); if (smbus_ret < 0) { - printk(BIOS_INFO, "No memory dimm at address %02X\n", addr); + printk(BIOS_INFO, "No memory dimm at address %02X\n", addr << 1); *sn = 0xffffffff; return CB_SUCCESS; } |