diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2023-10-31 09:02:26 -0500 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2023-11-02 13:25:41 +0000 |
| commit | 19799b4cd9f942ac085d3f0eaedaf0dd0b39be3a (patch) | |
| tree | ac6c779830bd69689cfd0b32247ba65a5034dfb5 /src/soc | |
| parent | 739f83eb0b3623024b45dd55eec3325892818041 (diff) | |
soc/intel/*: Correct ACPI device name for eMMC
The ACPI name of any device needs to match the name used for generating
the S0i3 LPI constraint list, which comes from soc_acpi_name() for each
SoC. The names used for the eMMC controller do not match, which will
lead to broken ACPI tables since the LPI constriant will reference
an ACPI device which does not exist. Some OSes tolerate this better
than others, but it should still be corrected.
TEST=build/boot google/{hatch,volteer, brya}, dump ACPI and verify
no invalid device names referenced.
Change-Id: Icbc22b6b2a84bbe73f1b09083f27081612db5eba
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78825
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Eric Lai <ericllai@google.com>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/intel/alderlake/acpi/scs.asl | 2 | ||||
| -rw-r--r-- | src/soc/intel/cannonlake/acpi/scs.asl | 2 | ||||
| -rw-r--r-- | src/soc/intel/elkhartlake/acpi/scs.asl | 2 | ||||
| -rw-r--r-- | src/soc/intel/jasperlake/acpi/scs.asl | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/intel/alderlake/acpi/scs.asl b/src/soc/intel/alderlake/acpi/scs.asl index aac78e8fcc..d39c66d83b 100644 --- a/src/soc/intel/alderlake/acpi/scs.asl +++ b/src/soc/intel/alderlake/acpi/scs.asl @@ -18,7 +18,7 @@ Scope (\_SB.PCI0) { } /* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name(TEMP, 0) diff --git a/src/soc/intel/cannonlake/acpi/scs.asl b/src/soc/intel/cannonlake/acpi/scs.asl index 7def761f75..fcadcbdc1c 100644 --- a/src/soc/intel/cannonlake/acpi/scs.asl +++ b/src/soc/intel/cannonlake/acpi/scs.asl @@ -15,7 +15,7 @@ Scope (\_SB.PCI0) { } /* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0) diff --git a/src/soc/intel/elkhartlake/acpi/scs.asl b/src/soc/intel/elkhartlake/acpi/scs.asl index c6d71c1faf..3955402a42 100644 --- a/src/soc/intel/elkhartlake/acpi/scs.asl +++ b/src/soc/intel/elkhartlake/acpi/scs.asl @@ -15,7 +15,7 @@ Scope (\_SB.PCI0) { } /* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0) diff --git a/src/soc/intel/jasperlake/acpi/scs.asl b/src/soc/intel/jasperlake/acpi/scs.asl index b58608feed..491df5163c 100644 --- a/src/soc/intel/jasperlake/acpi/scs.asl +++ b/src/soc/intel/jasperlake/acpi/scs.asl @@ -15,7 +15,7 @@ Scope (\_SB.PCI0) { } /* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0) |