diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-01-28 04:23:21 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-02-07 17:21:43 +0000 |
| commit | 12ec7901b773bb55640cbb96d9af103cb5006cda (patch) | |
| tree | 49678d88052a0ff1a5577dc1d5dbf169346f0119 /src/soc | |
| parent | fc84a555dacf490eaa57a457d8823db1f99e9e0c (diff) | |
soc/amd/stoneyridge/acpi: use acpigen_write_processor_device
Since things are done a bit differently on Stoneyridge, it's probably
safer to run a test instead of assuming that the test on Picasso was
sufficient to be reasonably sure that this will also work as expected on
Stoneyridge.
TEST=No change of ACPI-related messages in dmesg with this patch.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I432752fae8be08d3cbd7d30215b350c4528c7206
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72495
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/amd/stoneyridge/acpi.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index c862c4d53d..be9349d096 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -107,14 +107,10 @@ void generate_cpu_entries(const struct device *device) printk(BIOS_DEBUG, "ACPI \\_SB report %d core(s)\n", cores); - /* Generate BSP \_SB.P000 */ - acpigen_write_processor(0, ACPI_GPE0_BLK, 6); - acpigen_pop_len(); - - /* Generate AP \_SB.Pxxx */ - for (cpu = 1; cpu < cores; cpu++) { - acpigen_write_processor(cpu, 0, 0); - acpigen_pop_len(); + /* Generate \_SB.Pxxx */ + for (cpu = 0; cpu < cores; cpu++) { + acpigen_write_processor_device(cpu); + acpigen_write_processor_device_end(); } acpigen_write_processor_package("PPKG", 0, cores); |