summaryrefslogtreecommitdiff
path: root/src/soc/qualcomm/ipq40xx
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-09-11 15:47:09 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-09-12 14:59:33 +0000
commite3a1247b15e756f01d9c25bc71fa2cf563de34a8 (patch)
treeb5b3757f41355f0e046968f4bdf3c06b51941914 /src/soc/qualcomm/ipq40xx
parent8395165eee0ab487993e78de52a63dbc669f6684 (diff)
include/console/uart: make index parameter unsigned
The UART index is never negative, so make it unsigned and drop the checks for the index to be non-negative. Change-Id: I64bd60bd2a3b82552cb3ac6524792b9ac6c09a94 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45294 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/soc/qualcomm/ipq40xx')
-rw-r--r--src/soc/qualcomm/ipq40xx/uart.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/qualcomm/ipq40xx/uart.c b/src/soc/qualcomm/ipq40xx/uart.c
index 265c25e28b..9c506111fa 100644
--- a/src/soc/qualcomm/ipq40xx/uart.c
+++ b/src/soc/qualcomm/ipq40xx/uart.c
@@ -87,7 +87,7 @@ static int valid_data = 0;
/* Received data */
static unsigned int word = 0;
-void uart_tx_byte(int idx, unsigned char data)
+void uart_tx_byte(unsigned int idx, unsigned char data)
{
int num_of_chars = 1;
void *base = uart_board_param.uart_dm_base;
@@ -195,7 +195,7 @@ unsigned int msm_boot_uart_dm_init(void *uart_dm_base)
*
* Initializes clocks, GPIO and UART controller.
*/
-void uart_init(int idx)
+void uart_init(unsigned int idx)
{
/* Note int idx isn't used in this driver. */
void *dm_base;
@@ -230,7 +230,7 @@ void ipq40xx_uart_init(void)
* @brief uart_tx_flush - transmits a string of data
* @param idx: string to transmit
*/
-void uart_tx_flush(int idx)
+void uart_tx_flush(unsigned int idx)
{
void *base = uart_board_param.uart_dm_base;
@@ -244,7 +244,7 @@ void uart_tx_flush(int idx)
*
* Returns the character read from serial port.
*/
-uint8_t uart_rx_byte(int idx)
+uint8_t uart_rx_byte(unsigned int idx)
{
uint8_t byte;