summaryrefslogtreecommitdiff
path: root/src/soc/mediatek/mt8188
diff options
context:
space:
mode:
authorYu-Ping Wu <yupingso@chromium.org>2024-08-23 16:07:15 +0800
committerFelix Held <felix-coreboot@felixheld.de>2024-08-24 12:51:50 +0000
commit62ae90eac240e3312bf4ea46279c5df206cb4dbf (patch)
tree4241aa5fbeab33b5354c85fd71f69866d2a44ebb /src/soc/mediatek/mt8188
parentb56f407614b58ab139bef3612195fbdf07670436 (diff)
soc/mediatek: Require MCU and DRAM blobs to exist
When the config of MCU firmware blob such as CONFIG_SPM_FIRMWARE is non-empty, we should always expect the file to exist. Similarly, since the device is unlikely to boot without the DRAM blob (assuming MRC_CACHE doesn't contain valid memory training data), dram.elf should always exist as well. Therefore, remove the check for the existence of the blobs. Build would fail if any of the blobs is missing. Change-Id: I755e7c5a70b34b0c3d3915ab339c65263688aad7 Signed-off-by: Yu-Ping Wu <yupingso@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84053 Reviewed-by: Yidi Lin <yidilin@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/mediatek/mt8188')
-rw-r--r--src/soc/mediatek/mt8188/Makefile.mk6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/soc/mediatek/mt8188/Makefile.mk b/src/soc/mediatek/mt8188/Makefile.mk
index 6a57da49db..727b3f8c7c 100644
--- a/src/soc/mediatek/mt8188/Makefile.mk
+++ b/src/soc/mediatek/mt8188/Makefile.mk
@@ -78,16 +78,14 @@ $(foreach fw, $(call strip_quotes,$(mcu-firmware-files)), \
$(eval $(fw)-file := $(MT8188_BLOB_DIR)/$(fw)) \
$(eval $(fw)-type := raw) \
$(eval $(fw)-compression := LZ4) \
- $(if $(wildcard $($(fw)-file)), $(eval cbfs-files-y += $(fw)), ) \
+ $(eval cbfs-files-y += $(fw)) \
)
DRAM_CBFS := $(CONFIG_CBFS_PREFIX)/dram
$(DRAM_CBFS)-file := $(MT8188_BLOB_DIR)/dram.elf
$(DRAM_CBFS)-type := stage
$(DRAM_CBFS)-compression := $(CBFS_PRERAM_COMPRESS_FLAG)
-ifneq ($(wildcard $($(DRAM_CBFS)-file)),)
- cbfs-files-y += $(DRAM_CBFS)
-endif
+cbfs-files-y += $(DRAM_CBFS)
$(objcbfs)/bootblock.bin: $(objcbfs)/bootblock.raw.bin
./util/mtkheader/gen-bl-img.py mt8183 sf $< $@