summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorJohnny Lin <johnny_lin@wiwynn.com>2023-07-06 13:15:24 +0800
committerFelix Held <felix-coreboot@felixheld.de>2023-07-07 13:56:02 +0000
commit908be4f6edd27ef84ceb904912b92656258a88c0 (patch)
tree3825607b917643590fc3a327674ca4461cdb1aa3 /src/soc/intel
parent222c44796cf7d496864d16cbab3d844d23068250 (diff)
soc/intel/xeon_sp/spr: Fix upd_display.c build error
Fix below build error after DISPLAY_UPD_DATA is selected: src/soc/intel/xeon_sp/spr/upd_display.c:131:29: error: variable 'old' set but not used [-Werror=unused-but-set-variable] 131 | const FSP_S_CONFIG *old; | ^~~ src/soc/intel/xeon_sp/spr/upd_display.c:130:29: error: variable 'new' set but not used [-Werror=unused-but-set-variable] 130 | const FSP_S_CONFIG *new; Change-Id: I43ed5fadab58e0d4dc824457c7a1bdf48511198e Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76342 Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/xeon_sp/spr/upd_display.c11
1 files changed, 3 insertions, 8 deletions
diff --git a/src/soc/intel/xeon_sp/spr/upd_display.c b/src/soc/intel/xeon_sp/spr/upd_display.c
index 078624db15..c69a9a0562 100644
--- a/src/soc/intel/xeon_sp/spr/upd_display.c
+++ b/src/soc/intel/xeon_sp/spr/upd_display.c
@@ -127,13 +127,8 @@ void soc_display_fspm_upd_params(const FSPM_UPD *fspm_old_upd, const FSPM_UPD *f
/* Display the UPD parameters for SiliconInit */
void soc_display_fsps_upd_params(const FSPS_UPD *fsps_old_upd, const FSPS_UPD *fsps_new_upd)
{
- const FSP_S_CONFIG *new;
- const FSP_S_CONFIG *old;
-
- old = &fsps_old_upd->FspsConfig;
- new = &fsps_new_upd->FspsConfig;
-
- printk(BIOS_DEBUG, "UPD values for SiliconInit:\n");
-
+ printk(BIOS_DEBUG, "Dump of original UPD values for SiliconInit:\n");
+ hexdump(fsps_old_upd, sizeof(*fsps_old_upd));
+ printk(BIOS_DEBUG, "Dump of updated UPD values for SiliconInit:\n");
hexdump(fsps_new_upd, sizeof(*fsps_new_upd));
}