diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-01-08 13:33:10 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-01-25 10:37:13 +0000 |
| commit | b218c20c0015da77377bbc1efc0fc2efbe204360 (patch) | |
| tree | b434177f4f31a95d0e33db768d870620ac4e11bb /src/soc/intel | |
| parent | c1d524b8c60981d43153a8e0112d8224ba43a889 (diff) | |
sb,soc/intel: Remove no-op APMC for C-state and P-state
Change-Id: I3c1aa7f68eb03f04ddb9c1a5e960e3e2050a029c
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49250
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel')
| -rw-r--r-- | src/soc/intel/baytrail/smihandler.c | 14 | ||||
| -rw-r--r-- | src/soc/intel/braswell/smihandler.c | 14 | ||||
| -rw-r--r-- | src/soc/intel/broadwell/pch/smihandler.c | 4 | ||||
| -rw-r--r-- | src/soc/intel/common/block/smm/smihandler.c | 14 | ||||
| -rw-r--r-- | src/soc/intel/denverton_ns/smihandler.c | 12 |
5 files changed, 0 insertions, 58 deletions
diff --git a/src/soc/intel/baytrail/smihandler.c b/src/soc/intel/baytrail/smihandler.c index 1a33444ca4..41eeedae0b 100644 --- a/src/soc/intel/baytrail/smihandler.c +++ b/src/soc/intel/baytrail/smihandler.c @@ -283,20 +283,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/braswell/smihandler.c b/src/soc/intel/braswell/smihandler.c index 7343d47933..138dc339df 100644 --- a/src/soc/intel/braswell/smihandler.c +++ b/src/soc/intel/braswell/smihandler.c @@ -262,20 +262,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/broadwell/pch/smihandler.c b/src/soc/intel/broadwell/pch/smihandler.c index 02c795e411..c6632da4fa 100644 --- a/src/soc/intel/broadwell/pch/smihandler.c +++ b/src/soc/intel/broadwell/pch/smihandler.c @@ -314,10 +314,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - break; - case APM_CNT_PST_CONTROL: - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 4aed3f8848..4625d34e4c 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -333,20 +333,6 @@ void smihandler_southbridge_apmc( reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: pmc_disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/denverton_ns/smihandler.c b/src/soc/intel/denverton_ns/smihandler.c index f00d9216ec..68e85192c0 100644 --- a/src/soc/intel/denverton_ns/smihandler.c +++ b/src/soc/intel/denverton_ns/smihandler.c @@ -222,18 +222,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; |