From b218c20c0015da77377bbc1efc0fc2efbe204360 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Fri, 8 Jan 2021 13:33:10 +0200 Subject: sb,soc/intel: Remove no-op APMC for C-state and P-state MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I3c1aa7f68eb03f04ddb9c1a5e960e3e2050a029c Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/49250 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/soc/intel/baytrail/smihandler.c | 14 -------------- src/soc/intel/braswell/smihandler.c | 14 -------------- src/soc/intel/broadwell/pch/smihandler.c | 4 ---- src/soc/intel/common/block/smm/smihandler.c | 14 -------------- src/soc/intel/denverton_ns/smihandler.c | 12 ------------ 5 files changed, 58 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/baytrail/smihandler.c b/src/soc/intel/baytrail/smihandler.c index 1a33444ca4..41eeedae0b 100644 --- a/src/soc/intel/baytrail/smihandler.c +++ b/src/soc/intel/baytrail/smihandler.c @@ -283,20 +283,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/braswell/smihandler.c b/src/soc/intel/braswell/smihandler.c index 7343d47933..138dc339df 100644 --- a/src/soc/intel/braswell/smihandler.c +++ b/src/soc/intel/braswell/smihandler.c @@ -262,20 +262,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/broadwell/pch/smihandler.c b/src/soc/intel/broadwell/pch/smihandler.c index 02c795e411..c6632da4fa 100644 --- a/src/soc/intel/broadwell/pch/smihandler.c +++ b/src/soc/intel/broadwell/pch/smihandler.c @@ -314,10 +314,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - break; - case APM_CNT_PST_CONTROL: - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 4aed3f8848..4625d34e4c 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -333,20 +333,6 @@ void smihandler_southbridge_apmc( reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* - * Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: pmc_disable_pm1_control(SCI_EN); break; diff --git a/src/soc/intel/denverton_ns/smihandler.c b/src/soc/intel/denverton_ns/smihandler.c index f00d9216ec..68e85192c0 100644 --- a/src/soc/intel/denverton_ns/smihandler.c +++ b/src/soc/intel/denverton_ns/smihandler.c @@ -222,18 +222,6 @@ static void southbridge_smi_apmc(void) reg8 = apm_get_apmc(); switch (reg8) { - case APM_CNT_CST_CONTROL: - /* Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; - case APM_CNT_PST_CONTROL: - /* Calling this function seems to cause - * some kind of race condition in Linux - * and causes a kernel oops - */ - break; case APM_CNT_ACPI_DISABLE: disable_pm1_control(SCI_EN); break; -- cgit v1.2.3