diff options
| author | Marc Jones <marcjones@sysproconsulting.com> | 2020-12-02 14:35:27 -0700 |
|---|---|---|
| committer | Marc Jones <marc@marcjonesconsulting.com> | 2020-12-11 15:57:44 +0000 |
| commit | 1403b917ac68e0e462716d3fd48d5ce44529ee06 (patch) | |
| tree | 87a04b1cf38074751a98261887c7c1a755928ce2 /src/soc/intel/xeon_sp | |
| parent | 79b2a150c7a18a61604b0d81f52a7c6ad8522b60 (diff) | |
soc/intel/common/block/lpc: Move southbridge_write_acpi_tables declaration
Move the southbridge_write_acpi_tables declaration from acpi.h to common
lpc_lib.h, as common LPC is always the caller. This removes a duplicate
declaration since all soc/intel devices use common LPC, but not all use
common ACPI. The southbridge_write_acpi_tables function is defined in acpi.c
with the other acpi functions.
Note that this would have the reverse problem if there is ever a non-common
LPC device.
Change-Id: I0590a028b11f34e423d8f0007e0653037b0849a0
Signed-off-by: Marc Jones <marcjones@sysproconsulting.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48251
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Jay Talbott <JayTalbott@sysproconsulting.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/xeon_sp')
| -rw-r--r-- | src/soc/intel/xeon_sp/acpi.c | 1 | ||||
| -rw-r--r-- | src/soc/intel/xeon_sp/include/soc/acpi.h | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 4fe8b206d3..4c17eeac39 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -7,6 +7,7 @@ #include <device/pci.h> #include <cbmem.h> #include <cpu/x86/smm.h> +#include <intelblocks/lpc_lib.h> #include <soc/acpi.h> #include <soc/cpu.h> #include <soc/intel/common/acpi.h> diff --git a/src/soc/intel/xeon_sp/include/soc/acpi.h b/src/soc/intel/xeon_sp/include/soc/acpi.h index 2f22c621e2..743251b5fc 100644 --- a/src/soc/intel/xeon_sp/include/soc/acpi.h +++ b/src/soc/intel/xeon_sp/include/soc/acpi.h @@ -19,8 +19,6 @@ typedef struct { unsigned long northbridge_write_acpi_tables(const struct device *device, unsigned long current, struct acpi_rsdp *rsdp); -unsigned long southbridge_write_acpi_tables(const struct device *device, - unsigned long current, struct acpi_rsdp *rsdp); uint32_t soc_read_sci_irq_select(void); int soc_madt_sci_irq_polarity(int sci); void soc_power_states_generation(int core, int cores_per_package); |