diff options
author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2024-01-25 15:15:00 +0100 |
---|---|---|
committer | Lean Sheng Tan <sheng.tan@9elements.com> | 2024-02-06 08:21:05 +0000 |
commit | 7a593ab0bb6ad33db39d49745a07b382996cc4e9 (patch) | |
tree | 849a01dcb8df397fa9f1cdffcb476472f52210ed /src/soc/intel/xeon_sp/smmrelocate.c | |
parent | fe33b2dd86e41be96a1943e381cadf2b3a722356 (diff) |
soc/intel/xeon_sp/smihandler: Lock SMM_FEATURE_CONTROL on all sockets
Remove hardcoded B:D:F numbers for the first socket and pass the PCI
addresses to be locked within SMM by using the smm_pci_resource_store.
This allows to lock down SMM on all sockets without knowing the actual
bus topology or PCI segment group at compile time where the UBOX devices
reside on.
Tested: SMM is locked on all 4 sockets instead of just one.
Change-Id: Ica694911384005681662d3d7bed354a60bf08911
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80247
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/xeon_sp/smmrelocate.c')
-rw-r--r-- | src/soc/intel/xeon_sp/smmrelocate.c | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/src/soc/intel/xeon_sp/smmrelocate.c b/src/soc/intel/xeon_sp/smmrelocate.c index f9d100a600..89f35c2319 100644 --- a/src/soc/intel/xeon_sp/smmrelocate.c +++ b/src/soc/intel/xeon_sp/smmrelocate.c @@ -7,9 +7,11 @@ #include <cpu/intel/em64t101_save_state.h> #include <cpu/intel/smm_reloc.h> #include <console/console.h> +#include <device/pci_ids.h> #include <smp/node.h> #include <soc/msr.h> #include <soc/smmrelocate.h> +#include <soc/pci_devs.h> static void fill_in_relocation_params(struct smm_relocation_params *params) { @@ -137,3 +139,21 @@ void smm_relocation_handler(int cpu, uintptr_t curr_smbase, if (mtrr_cap.lo & SMRR_SUPPORTED) write_smrr(relo_params); } + +void soc_ubox_store_resources(struct smm_pci_resource_info *slots, size_t size) +{ + struct device *devices[CONFIG_MAX_SOCKET] = {0}; + size_t devices_count = 0; + struct device *dev = NULL; + + /* + * Collect all UBOX DFX devices. Depending on the actual socket count + * the bus numbers changed and the PCI segment group might be different. + * Pass all devices to SMM for platform lockdown. + */ + while ((dev = dev_find_device(PCI_VID_INTEL, UBOX_DFX_DEVID, dev))) { + devices[devices_count++] = dev; + } + + smm_pci_resource_store_fill_resources(slots, size, (const struct device **)devices, devices_count); +} |