diff options
| author | Subrata Banik <subratabanik@google.com> | 2024-08-13 18:08:56 +0000 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2024-08-15 06:28:33 +0000 |
| commit | 0b2f9c9582af96fa3de82e2e7ab7c4f99119e1a4 (patch) | |
| tree | 21bb250b01c1aa505ba04bc0bc74eeb55b1e0ed1 /src/soc/intel/xeon_sp/gnr/chip.h | |
| parent | 7de29115893c30832fb136de1d6b2b9d2dc4d968 (diff) | |
soc/intel/alderlake: Correct ISH partition availability check
The previous implementation incorrectly assumed that the presence of a
UFS device implied the availability of the ISH partition. This is not
always true, especially on Alder Lake platforms where ISH may be
enabled by default even without UFS.
This patch fixes the issue by directly checking for the presence of the
ISH device to determine if the ISH partition is available.
BUG=b:359440547
TEST=1. Able to dump the ISH version with UFS device:
```
tirwen-rev3 ~ # cbmem -c -1 | grep ISH
[DEBUG] ISH version: 5.4.2.7780
```
2. Able to dump the ISH version with eMMC device:
```
trulo-rev1 ~ # cbmem -c | grep ISH
[DEBUG] ISH version: 5.4.2.7780
```
Change-Id: I411e36606c0697f91050af40e0636f7c64810e95
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83898
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Dinesh Gehlot <digehlot@google.com>
Reviewed-by: Eric Lai <ericllai@google.com>
Diffstat (limited to 'src/soc/intel/xeon_sp/gnr/chip.h')
0 files changed, 0 insertions, 0 deletions