summaryrefslogtreecommitdiff
path: root/src/soc/intel/meteorlake
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2022-12-08 16:05:40 +0530
committerSubrata Banik <subratabanik@google.com>2022-12-10 08:02:42 +0000
commitff433b71765d91673aac6cc25b16a41bdb564645 (patch)
tree9a64857ba234ab129897ce5aae4ee714e05bd11b /src/soc/intel/meteorlake
parent49204e30f390737724ee8fc3f57dfb4dc4a5bcbc (diff)
soc/intel: Move TCSS FW latency macros to IA common tcss.h
This patch moves TCSS firmware latency related macros from SoC specific tcss.h to IA common tcss.h Additionally, ensure other structure definitions belonging to the IA common code tcss.h are not causing compilation issues for ASL files (due to including FW latency macros) hence, guarded against `!defined(__ACPI__)`. TEST=Able to build and boot Google/Rex and Google/Kano. Change-Id: Id51545ef714979c6ba09a2b468231b1f4bab0be7 Signed-off-by: Subrata Banik <subratabanik@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70487 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/meteorlake')
-rw-r--r--src/soc/intel/meteorlake/acpi/tcss.asl2
-rw-r--r--src/soc/intel/meteorlake/include/soc/tcss.h20
2 files changed, 1 insertions, 21 deletions
diff --git a/src/soc/intel/meteorlake/acpi/tcss.asl b/src/soc/intel/meteorlake/acpi/tcss.asl
index cd964c4594..6635d085b4 100644
--- a/src/soc/intel/meteorlake/acpi/tcss.asl
+++ b/src/soc/intel/meteorlake/acpi/tcss.asl
@@ -1,7 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
+#include <intelblocks/tcss.h>
#include <soc/iomap.h>
-#include <soc/tcss.h>
/*
* Type C Subsystem(TCSS) topology provides Runtime D3 support for USB host controller(xHCI),
diff --git a/src/soc/intel/meteorlake/include/soc/tcss.h b/src/soc/intel/meteorlake/include/soc/tcss.h
index 439606c6af..014e3076e6 100644
--- a/src/soc/intel/meteorlake/include/soc/tcss.h
+++ b/src/soc/intel/meteorlake/include/soc/tcss.h
@@ -13,24 +13,4 @@
#define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 0x1088
#define IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET(x) (IOM_AUX_BIAS_CTRL_PULLDOWN_OFFSET_0 + (x) * 4)
-/*
- * The PCI-SIG engineering change requirement provides the ACPI additions for firmware latency
- * optimization. Both of FW_RESET_TIME and FW_D3HOT_TO_D0_TIME are applicable to the upstream
- * port of the USB4/TBT topology.
- */
-/* Number of microseconds to wait after a conventional reset */
-#define FW_RESET_TIME 50000
-
-/* Number of microseconds to wait after data link layer active report */
-#define FW_DL_UP_TIME 1
-
-/* Number of microseconds to wait after a function level reset */
-#define FW_FLR_RESET_TIME 1
-
-/* Number of microseconds to wait from D3 hot to D0 transition */
-#define FW_D3HOT_TO_D0_TIME 50000
-
-/* Number of microseconds to wait after setting the VF enable bit */
-#define FW_VF_ENABLE_TIME 1
-
#endif /* _SOC_TCSS_H_ */