diff options
| author | Subrata Banik <subratabanik@google.com> | 2023-02-17 03:18:50 +0530 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2023-02-17 08:30:24 +0000 |
| commit | e70bc423f9a2e1d13827f2703efe1f9c72549f20 (patch) | |
| tree | 0bff67a39bf500fe40cf7c6e423dab27b1689ad2 /src/soc/intel/meteorlake/chip.c | |
| parent | 8b223d43ce5e00b08fe19bdb044344b4e98e7a22 (diff) | |
soc/intel/meteorlake: Improve `incomplete` debug message
This patch improves `incomplete` debug messages for missing ACPI
name PCI devices.
Additionally, using the proper PCI device B:D:F to locate the device
with the missing ACPI name.
Finally, modify the msg time from Debug to Warning to make it more
purposeful.
TEST=Able to build and boot google/rex.
Without this patch:
```
[DEBUG] dev->path.devfn=10
[DEBUG] dev->path.devfn=a2
[DEBUG] dev->path.devfn=b0
```
With this patch:
```
[WARN] Missing ACPI Name for PCI: 00:02.0
[WARN] Missing ACPI Name for PCI: 00:14.2
[WARN] Missing ACPI Name for PCI: 00:16.0
```
Change-Id: I605e59de8cbec18c9a56eaa6e90a34f36ea4cdd9
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73072
Reviewed-by: Tarun Tuli <taruntuli@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Diffstat (limited to 'src/soc/intel/meteorlake/chip.c')
| -rw-r--r-- | src/soc/intel/meteorlake/chip.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/soc/intel/meteorlake/chip.c b/src/soc/intel/meteorlake/chip.c index 80b3cdb27e..60f85ba983 100644 --- a/src/soc/intel/meteorlake/chip.c +++ b/src/soc/intel/meteorlake/chip.c @@ -113,7 +113,8 @@ const char *soc_acpi_name(const struct device *dev) case PCI_DEVFN_SMBUS: return "SBUS"; case PCI_DEVFN_GBE: return "GLAN"; } - printk(BIOS_DEBUG, "dev->path.devfn=%x\n", dev->path.pci.devfn); + printk(BIOS_DEBUG, "Missing ACPI Name for PCI: 00:%02x.%01x\n", + PCI_SLOT(dev->path.pci.devfn), PCI_FUNC(dev->path.pci.devfn)); return NULL; } #endif |